Merged
Conversation
dpebot
force-pushed
the
dpebot-repositorygardener
branch
from
bccaf75 to
f49da6f
Compare
googlebot
added
the
cla: yes
dpebot
force-pushed
the
dpebot-repositorygardener
branch
from
f49da6f to
45a9da7
Compare
|
Looks like there was a Spanner test failure. @dzlier-gcp, is that something you can take a look at? |
Member
|
The spanner test always fails if you let it update the version of apache
beam. I have to manually revert that version every time.
…On Thu, Aug 9, 2018 at 5:17 AM Tyler Bui-Palsulich ***@***.***> wrote:
Looks like there was a Spanner test failure. @dzlier-gcp
<https://github.com/dzlier-gcp>, is that something you can take a look at?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1175 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfW2ctltVmPUrVT2j6kjZuf198ihq4s2ks5uPChngaJpZM4VzLj5>
.
|
Member
|
The spanner test always fails if you let it update the version of apache beam. I have to manually revert that version every time. I'd say we could just mark the test as ignored, but the bigger problem is that that code block is linked to directly on the spanner page, so if anyone copies it and the apache beam dependencies, they will get the same error. |
Member
|
@dpebot merge when green |
Contributor
Author
|
Okay! I'll merge when all statuses are green and all reviewers approve. |
dzlier-gcp
previously approved these changes
Aug 9, 2018
Update KMS test regexes to account for new "protectionLevel" field in output.
dzlier-gcp
force-pushed
the
dpebot-repositorygardener
branch
from
5932005 to
4a956b0
Compare
dzlier-gcp
approved these changes
Aug 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought to you by your friendly Repository Gardener.