Add speech beta samples by nirupa-kumar · Pull Request #1151 · GoogleCloudPlatform/java-docs-samples

nirupa-kumar · 2018-07-12T20:07:59Z

Diarization,Multi-channel, Multi-language and Word level confidence
@nnegrey Please review

…rd level confidence

googlebot · 2018-07-12T20:08:02Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

nnegrey

Couple small things here and there, looks good and thanks for updating the code.

nnegrey · 2018-07-17T15:30:07Z

speech/cloud-client/pom.xml

      <groupId>com.google.cloud</groupId>
      <artifactId>google-cloud-speech</artifactId>
-      <version>0.52.0-alpha</version>
+      <version>0.52.1-alpha-SNAPSHOT</version>


Update lib version when released.

nnegrey · 2018-07-17T15:37:15Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+              .setSampleRateHertz(8000)
+              .setEnableSpeakerDiarization(true)
+              .setDiarizationSpeakerCount(2)
+              .setEnableAutomaticPunctuation(true)


Let's remove the automatic punctuation for this sample. Unless its needed.

+1 Especially in a sample, it should only have the minimum needed to get the feature you're demonstrating working.

nnegrey · 2018-07-17T15:37:40Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+              .setEnableSpeakerDiarization(true)
+              .setDiarizationSpeakerCount(2)
+              .setEnableAutomaticPunctuation(true)
+              .setModel("phone_call")


Are models required here? If not, remove.

nnegrey · 2018-07-17T15:42:29Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+            "Speaker Tag : %s \n",
+            alternative.getWords((alternative.getWordsCount() - 1)).getSpeakerTag());
+        System.out.format(
+            "Word: %s\n\n", alternative.getWords((alternative.getWordsCount() - 1)).getWord());


Lines: 838-841:
Is this printing out the last speaker and their last word?

Is is possible to maybe do something like: (Not sure what the results look like)
Speaker Tag ###: Hey, how are you?
Speaker Tag ***: I'm doing good.

Thoughts?

It is printing out the last speaker and last word. The words array contains the entire transcript up until that point.
Speaker Tag ###: Hey, how are you? : Definitely makes more sense. Will switch it out.

Can you add this as a comment? ie the explanation of why you're getting the last word of the alternative instead of, say, all the words or the first word.

nnegrey · 2018-07-17T15:43:13Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+              .setEnableSpeakerDiarization(true)
+              .setDiarizationSpeakerCount(2)
+              .setEnableAutomaticPunctuation(true)
+              .setModel("phone_call")


Same as above, remove setEnableAutomaticPunctuation, and setModel (if possible)

nnegrey · 2018-07-17T15:45:07Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+              .setSampleRateHertz(44100)
+              .setAudioChannelCount(2)
+              .setEnableSeparateRecognitionPerChannel(true)
+              .setEnableAutomaticPunctuation(true)


Remove setEnableAutomaticPunctuation (if possible)

nnegrey · 2018-07-17T15:45:12Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+      RecognitionAudio recognitionAudio =
+          RecognitionAudio.newBuilder().setContent(ByteString.copyFrom(content)).build();
+
+      // Configure request to enable enhanced models


Update comment

// Configure request to enable multiple channels

nnegrey · 2018-07-17T15:46:16Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+              .setSampleRateHertz(44100)
+              .setAudioChannelCount(2)
+              .setEnableSeparateRecognitionPerChannel(true)
+              .setEnableAutomaticPunctuation(true)


nnegrey · 2018-07-17T15:47:46Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+    try (SpeechClient speechClient = SpeechClient.create()) {
+      RecognitionAudio recognitionAudio =
+          RecognitionAudio.newBuilder().setContent(ByteString.copyFrom(content)).build();
+      // Configure request to enable multiple channels


Update comment

nnegrey · 2018-07-17T15:48:43Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+  public static void transcribeWordLevelConfidenceGcs(String gcsUri) throws Exception {
+    try (SpeechClient speechClient = SpeechClient.create()) {
+
+      // Configure request to enable multiple channels


Update commment

…docs-samples into speech-beta

jerjou · 2018-07-17T22:37:00Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

-      StreamingRecognitionConfig config = StreamingRecognitionConfig.newBuilder()
-          .setConfig(recConfig)
-          .build();
+      RecognitionConfig recConfig =


It'd be helpful if you could do these formatting changes in a separate PR, so that there isn't this giant diff of unrelated changes for reviewers to review..

Sorry, given my access issues, I'm not sure how it may affect creating a separate PR. Putting everything together in one for now.

jerjou · 2018-07-17T22:37:42Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+              .setSampleRateHertz(8000)
+              .setEnableSpeakerDiarization(true)
+              .setDiarizationSpeakerCount(2)
+              .setEnableAutomaticPunctuation(true)


+1 Especially in a sample, it should only have the minimum needed to get the feature you're demonstrating working.

jerjou · 2018-07-17T22:38:54Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+            "Speaker Tag : %s \n",
+            alternative.getWords((alternative.getWordsCount() - 1)).getSpeakerTag());
+        System.out.format(
+            "Word: %s\n\n", alternative.getWords((alternative.getWordsCount() - 1)).getWord());


Can you add this as a comment? ie the explanation of why you're getting the last word of the alternative instead of, say, all the words or the first word.

nirupa-kumar · 2018-07-18T08:46:53Z

All changes done. Please let me know if this is good to merge.

nnegrey

2 small things

nnegrey · 2018-07-18T16:44:02Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+        System.out.format("Transcript : %s\n", alternative.getTranscript());
+        // The words array contains the entire transcript up until that point.
+        //Referencing the last spoken word to get the associated Speaker tag
+        System.out.format("Speaker Tag %s:%s\n",


Add a space between %s:%s --> %s: %s

nnegrey · 2018-07-18T16:46:32Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+      RecognitionAudio recognitionAudio =
+          RecognitionAudio.newBuilder().setContent(ByteString.copyFrom(content)).build();
+
+      // Configure request to enable enhanced models


// Configure request to enable multiple channels

nirupa-kumar · 2018-07-18T17:47:51Z

I signed it!

nirupa-kumar · 2018-07-18T18:25:14Z

All changes have been made.

nirupa-kumar · 2018-07-20T04:51:50Z

Checking if this triggers the CLA bot

nirupa-kumar · 2018-07-20T04:59:43Z

@nnegrey - Updated the client library too. Please let me know if this is good to merge

googlebot · 2018-07-20T17:37:24Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

nnegrey · 2018-07-20T17:37:26Z

Per an email from OSPO, nirupa-kumar has a signed CLA.

googlebot · 2018-07-20T17:58:12Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot · 2018-07-20T18:07:01Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

googlebot · 2018-07-20T18:07:28Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot · 2018-07-20T18:07:57Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

…docs-samples into speech-beta

googlebot · 2018-07-20T19:32:57Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot · 2018-07-20T19:49:22Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

nnegrey

LGTM

* Speech beta samples: Diarization,Multi-channel, Multi-language and Word level confidence * Update client library * Updates after review * Updates after review : Please let this be the last one :) * Update to released client library * Update to Inc. * Update to Inc. * Update to reference bucket for files

### Migrating samples from [googleapis/java-speech](https://togithub.com/googleapis/java-speech/tree/main/samples) into [java-docs-samples/speech](https://togithub.com/GoogleCloudPlatform/java-docs-samples) --- - samples: Speech GA - library update (#1212) - samples: Due to API backend changes, update the samples to match (#1595) - fix: update retry configs, adds generated samples (#26) - build: move clirr to separate check (#30) - feat: add speaker_tag to WordInfo (#40) - chore: update common templates, regenerate tests - samples: Fix flaky speech test for speaker diarization (#1829) - chore(regen): update license year for generated files (#82) - chore(regen): regenerate with updated year - samples: move generated samples to generated directory (#105) - chore: update common templates - samples: fix: flaky tests in speech (#2286) - samples: speech: move samples out of branch (#2324) - samples: scaffold pom.xml files (#118) - chore(deps): update dependency com.google.cloud:libraries-bom to v4.3.0 (#122) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.13 (#126) - samples: update shared config (#2443) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.14 (#130) - chore(deps): update dependency com.google.cloud:libraries-bom to v4.4.0 (#131) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.15 (#133) - chore(deps): update dependency com.google.cloud:libraries-bom to v4.4.1 (#134) - chore(deps): update dependency com.google.cloud:libraries-bom to v5 (#144) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.16 (#149) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.17 (#153) - chore: fix samples snippets and update name in repo-metadata (#155) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.2.0 (#160) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.3.0 (#167) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.5.0 (#177) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.18 (#200) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.7.0 (#199) - chore(deps): update dependency com.google.cloud:libraries-bom to v6 (#210) - chore(deps): update dependency com.google.cloud:libraries-bom to v7 (#214) - chore(deps): update dependency com.google.cloud:libraries-bom to v7.0.1 (#222) - chore(deps): update dependency com.google.cloud:libraries-bom to v8 (#227) - chore(deps): update dependency com.google.cloud:libraries-bom to v8.1.0 (#237) - samples: Add Speech API quickstart sample. (#497) - samples: Adds sync / async examples for local and remote files - samples: Fixes whitespace around while blocks - samples: Adds some basic javadocs and comments - samples: Infer project from env - samples: Updates to use v1 release. - samples: Fixes checkstyle issues. - samples: Adds streaming example and tests. - samples: Nits found in self-review. - samples: Removes commented out code snippet and adds note on async local file limit. - samples: Speech async examples (#612) - samples: Vision speech upgrade (#641) - samples: updating to latest google-cloud-* dependencies (#723) - samples: Upgrades client and addresses changes to long running operations - samples: Adds support for word time offset - samples: Minimizes cloud maven dependencies and fixes lint warnings - samples: Fixes seconds reported in word time offsets and enables maven checks - samples: Updates to highlight word time offsets (#787) - samples: Use only first alternative. Comments for clarity (#837) - samples: Auto-update dependencies. (#853) - samples: Auto-update dependencies. (#912) - samples: Updated mlengine, monitoring, pubsub, spanner, and speech. (#993) - samples: Speech samples (#1036) - samples: Add model selection to streaming sample (#1073) - samples: Model selection (#1074) - samples: Add Auto-Punctuation samples to speech (#1079) - samples: Add samples for enhanced models and metadata (#1093) - samples: Add speech beta samples (#1151) - samples: [DO_NOT_MERGE] Microphone streaming with a 1 minute duration. (#1185) - samples: Speech region tag update (#1188) - samples: updates word time offsets region tag (#1191) - samples: Speech GA - library update (#1212) - samples: Bump QuickStartSample to v1 (#1285) - samples: Infinite Stream recognition (#1297) - samples: Speech multi-channel GA (#1341) - samples: Data logging opt-in is no longer required for enhanced models (#1360) - samples: Updated Infinite streaming sample (#1422) - samples: Revert Tests, product team rolled back changes, Auto Punctuation behavior is back to the expected output (#1428) - samples: Increase timeout to 5 mins (#1453) - samples: Update Recognize.java (#1460) - samples: Add back missing break statement (#1512) - samples: Added command line option class + option to pass different lang code as argument (#1504) - samples: Update a default value to parameter (#1522) - samples: Add samples for speech diarization ga (auto-punctuation samples alrea… (#1744) - samples: speech: add ga samples and fix some flaky tests (#2049) - samples: update shared config (#2443) - samples: speech: make flaky tests generic (#2825) - samples: fix test dependencies - chore(deps): update dependency com.google.cloud:libraries-bom to v9 (#263) - chore(deps): update dependency com.google.cloud:libraries-bom to v10 (#271) - chore(deps): update dependency com.google.cloud:libraries-bom to v11 - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.21 (#294) - chore(deps): update dependency com.google.cloud:libraries-bom to v12 (#298) - test(deps): update dependency junit:junit to v4.13.1 - chore(deps): update dependency com.google.cloud:libraries-bom to v12.1.0 (#310) - chore(deps): update dependency com.google.cloud:libraries-bom to v13 (#321) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.1.0 (#326) - test(deps): update dependency com.google.truth:truth to v1.1 (#322) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.2.0 (#332) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.3.0 (#334) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.4.0 (#338) - chore(deps): update dependency com.google.cloud:libraries-bom to v14 (#347) - chore(deps): update dependency com.google.cloud:libraries-bom to v15 (#350) - chore(deps): update dependency com.google.cloud:libraries-bom to v15.1.0 (#357) - chore(deps): update dependency com.google.cloud:libraries-bom to v16 (#364) - samples: add recognize sample with profanity filter (#376) - samples: refactor quickstart to use a gcs file (#378) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.2.0 (#389) - samples: add multi region transcribe sample (#394) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.2.1 (#398) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.3.0 (#405) - test(deps): update dependency com.google.truth:truth to v1.1.2 (#407) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.4.0 (#423) - test(deps): update dependency junit:junit to v4.13.2 (#428) - chore(deps): update dependency com.google.cloud:libraries-bom to v17 (#441) - chore(deps): update dependency com.google.cloud:libraries-bom to v18 (#445) - chore(deps): update dependency com.google.cloud:libraries-bom to v18.1.0 (#456) - chore(deps): update dependency com.google.cloud:libraries-bom to v19 (#459) - chore(samples): adds model adaptation sample (#468) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.22 (#482) - chore(deps): update dependency com.google.cloud:libraries-bom to v20 (#486) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.1.0 (#493) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.2.0 (#505) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.3.0 (#514) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.4.0 (#523) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.5.0 (#535) - test(deps): update dependency com.google.truth:truth to v1.1.3 (#537) - chore: change region (#538) - samples: adds export to GCS sample (#544) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.6.0 (#552) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.23 (#551) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.7.0 (#568) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.8.0 (#578) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.9.0 (#589) - chore(deps): update dependency com.google.cloud:libraries-bom to v21 (#625) - chore(deps): update dependency com.google.cloud:libraries-bom to v22 (#650) - chore(deps): update dependency com.google.cloud:libraries-bom to v23 (#663) - chore: migrate to owlbot (#660) - chore(deps): update dependency com.google.cloud:libraries-bom to v23.1.0 (#702) - chore(deps): update dependency com.google.cloud:libraries-bom to v24 (#719) - deps: update dependency commons-cli:commons-cli to v1.5.0 (#720) - sample: Configure polling algorithm in long recognition sample (#464) - chore: cleanup cloud RAD generation (#1269) (#725) - docs(samples): refactors the export-to-gcs sample (#737) - deps: update dependency org.json:json to v20211205 (#745) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.24 (#742) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.2.0 (#753) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.0 (#758) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.1 (#759) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.2 (#764) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.2.0 (#775) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.3.0 (#794) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.4.0 (#823) - deps: update dependency org.json:json to v20220320 (#835) - chore(deps): update dependency com.google.cloud:libraries-bom to v25 (#834) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.1.0 (#849) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.2.0 (#876) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.3.0 (#883) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.4.0 (#892) - chore(deps): update dependency com.google.cloud:libraries-bom to v26 (#918) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.0 (#938) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.1 (#941) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.2 (#957) - deps: update dependency org.json:json to v20220924 (#961) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.3 (#975) Fixes #issue > It's a good idea to open an issue first for discussion. - [ ] I have followed [Sample Format Guide](https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md) - [ ] `pom.xml` parent set to latest `shared-configuration` - [ ] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [ ] **Tests** pass: `mvn clean verify` **required** - [ ] **Lint** passes: `mvn -P lint checkstyle:check` **required** - [ ] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only** - [ ] Please **merge** this PR for me once it is approved.

Speech beta samples: Diarization,Multi-channel, Multi-language and Wo…

949ebf8

…rd level confidence

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 12, 2018

nirupa-kumar changed the title ~~[DO_NOT _MERGE] Add speech beta samples~~ Add speech beta samples Jul 13, 2018

nnegrey suggested changes Jul 17, 2018

View reviewed changes

nirupa-kumar added 2 commits July 17, 2018 12:02

Update client library

99b077e

Merge branch 'master' of https://github.com/GoogleCloudPlatform/java-…

e633d0d

…docs-samples into speech-beta

jerjou reviewed Jul 17, 2018

View reviewed changes

Updates after review

a8cee0e

nnegrey suggested changes Jul 18, 2018

View reviewed changes

Updates after review : Please let this be the last one :)

ac840d5

Update to released client library

10e7dba

nnegrey added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2018

googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Jul 20, 2018

nirupa-kumar added 2 commits July 20, 2018 10:57

Update to Inc.

c23d23f

Update to Inc.

48748b9

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 20, 2018

nnegrey added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2018

googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Jul 20, 2018

Merge branch 'master' into speech-beta

6933853

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 20, 2018

nnegrey added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2018

googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Jul 20, 2018

nirupa-kumar added 3 commits July 20, 2018 12:29

Update to reference bucket for files

0af8dc7

Merge branch 'master' of https://github.com/GoogleCloudPlatform/java-…

9b94dc3

…docs-samples into speech-beta

Merge remote-tracking branch 'origin/speech-beta' into speech-beta

7382891

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 20, 2018

nnegrey added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2018

googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Jul 20, 2018

nnegrey approved these changes Jul 20, 2018

View reviewed changes

nnegrey merged commit 857163d into GoogleCloudPlatform:master Jul 20, 2018

CallistoCF mentioned this pull request Jul 24, 2018

Code Samples for new v1p1beta1 features googleapis/nodejs-speech#118

Merged

3 tasks

Shabirmean mentioned this pull request Nov 17, 2022

samples: migrate code from googleapis/java-speech #7437

Merged

9 tasks

Conversation

nirupa-kumar commented Jul 12, 2018

Uh oh!

googlebot commented Jul 12, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

nnegrey left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nirupa-kumar commented Jul 18, 2018

Uh oh!

nnegrey left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nirupa-kumar commented Jul 18, 2018

Uh oh!

nirupa-kumar commented Jul 18, 2018

Uh oh!

nirupa-kumar commented Jul 20, 2018

Uh oh!

nirupa-kumar commented Jul 20, 2018

Uh oh!

googlebot commented Jul 20, 2018

Uh oh!

nnegrey commented Jul 20, 2018

Uh oh!

googlebot commented Jul 20, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented Jul 20, 2018

Uh oh!

googlebot commented Jul 20, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!