Embed balancer.ClientConn in MockClientConn #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In grpc/grpc-go#8026, grpc-go plans to enforce users embed existing instances of a ClientConn in their ClientConn wrappers. This allows gRPC Go to add methods to the interface without breaking users, the new methods would be passed through the embedded ClientConn. To avoid breaking the tests using the MockBalancer generated by gomock, this PR manually edits the mock to embed the interface.
A similar PR (#89) was set out when grpc-go was enforcing an embedding requirement for implementors of balancer.SubConn.