Ensure checksum errors result in error#2887
Merged
briandealwis merged 1 commit intomasterfrom Mar 6, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2887 +/- ##
============================================
+ Coverage 68.86% 68.92% +0.06%
- Complexity 2587 2591 +4
============================================
Files 353 353
Lines 12369 12371 +2
Branches 1468 1468
============================================
+ Hits 8518 8527 +9
+ Misses 3244 3241 -3
+ Partials 607 603 -4
Continue to review full report at Codecov.
|
chanseokoh
approved these changes
Mar 5, 2018
elharo
approved these changes
Mar 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maven's default
checksumPolicyappears to bewarn. This patch sets the checksum policy in ourDependencyResolverto fail.Unfortunately I can't figure out how to inject a
RepositoryConnectororTransporter(or one of their providers or factories) to try to inject a transfer failure to test, but I did verify with a breakpoint that the checksum policy was set toerror.