Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): update opentelemetry-go-contrib monorepo to v0.59.0 #4902

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Dec 23, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
go.opentelemetry.io/contrib/exporters/autoexport v0.53.0 -> v0.59.0 age adoption passing confidence
go.opentelemetry.io/contrib/propagators/autoprop v0.53.0 -> v0.59.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "* 0-3 * * 1" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

forking-renovate bot commented Dec 23, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: opentelemetry/instrumentation/app/go.sum
Command failed: install-tool golang 1.21.13

@renovate-bot renovate-bot requested review from a team as code owners December 23, 2024 00:33
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 23, 2024
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by Renovate, updates several OpenTelemetry Go contrib packages to their latest versions. The goal is to keep the golang-samples repository using the most up-to-date and secure versions of these libraries. This is a dependency update PR, and therefore no functional changes are expected.

Here's a breakdown of the changes:

  • Updated Packages:

    • go.opentelemetry.io/contrib/detectors/gcp: Updated from v1.28.0 to v1.33.0
    • go.opentelemetry.io/contrib/exporters/autoexport: Updated from v0.53.0 to v0.58.0
    • go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp: Updated from v0.53.0 to v0.58.0
    • go.opentelemetry.io/contrib/propagators/autoprop: Updated from v0.53.0 to v0.58.0
  • Affected Files: The changes are reflected in the go.mod files within the opentelemetry/instrumentation/app and opentelemetry/trace directories. Specifically, the version numbers for the listed packages are updated within these files.

The full release notes for the updated opentelemetry-go-contrib monorepo are quite extensive and included in the PR description. I recommend reviewing them for a complete picture of all changes in the underlying libraries.


And now, a little haiku to lighten the mood:

Dependencies flow,
New versions, fresh and clean code,
Smooth sailing ahead.

Thanks,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates several packages in the opentelemetry-go-contrib monorepo. It's good practice to keep dependencies up-to-date, and the provided table in the description is helpful for understanding the changes at a high level. The release notes are extensive and provide good context. However, consider summarizing the key changes and their potential impact on the project in the PR description itself. This will make it easier for reviewers to quickly assess the importance and risk of the update.

I've studied the release notes and the diff hunks and offer the following suggestions.

Comment on lines 9 to 11
go.opentelemetry.io/contrib/exporters/autoexport v0.58.0
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.58.0
go.opentelemetry.io/contrib/propagators/autoprop v0.58.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating these opentelemetry-go-contrib packages is a good step. Could you elaborate in the PR description on why these specific versions were chosen? For example, are there any new features or bug fixes that are particularly relevant to this project? Referencing specific issues or sections of the release notes would be helpful. Additionally, it's important to consider the impact of dependency updates on the project's overall stability and performance. Are there any breaking changes introduced by these new versions? How do these updates affect the size and performance of the application?

@@ -6,7 +6,7 @@ require (
cloud.google.com/go/trace v1.10.10
github.com/GoogleCloudPlatform/golang-samples v0.0.0-20240724083556-7f760db013b7
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace v1.24.1
go.opentelemetry.io/contrib/detectors/gcp v1.28.0
go.opentelemetry.io/contrib/detectors/gcp v1.33.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The update to go.opentelemetry.io/contrib/detectors/gcp from v1.28.0 to v1.33.0 is significant. The release notes mention several changes, including added support for SNS instrumentation and fixes for AWS presigned URLs and OTLP exporter configuration. It's important to ensure that these changes don't introduce any regressions in the project. Do you have any tests in place to verify the behavior of the GCP resource detector after this update? Specifically, it would be beneficial to add tests that cover the following scenarios:

  • Verify that the resource detector correctly identifies the GCP environment.
  • Ensure that the expected resource attributes are being collected.
  • Confirm that no unexpected attributes are being added.
  • Test any new functionality introduced in the updated version, such as SNS instrumentation support.

Consider adding these tests to the opentelemetry/trace/main_test.go file.

@renovate-bot renovate-bot changed the title chore(all): update opentelemetry-go-contrib monorepo chore(all): update opentelemetry-go-contrib monorepo to v0.58.0 Jan 6, 2025
@renovate-bot renovate-bot changed the title chore(all): update opentelemetry-go-contrib monorepo to v0.58.0 chore(all): update opentelemetry-go-contrib monorepo Jan 6, 2025
@telpirion telpirion self-assigned this Jan 6, 2025
@renovate-bot renovate-bot force-pushed the renovate/opentelemetry-go-contrib-monorepo branch 2 times, most recently from 8c86732 to 0a3d491 Compare January 17, 2025 22:28
@renovate-bot renovate-bot force-pushed the renovate/opentelemetry-go-contrib-monorepo branch from 0a3d491 to f701fab Compare January 23, 2025 00:40
@renovate-bot renovate-bot changed the title chore(all): update opentelemetry-go-contrib monorepo chore(all): update opentelemetry-go-contrib monorepo to v0.59.0 Jan 23, 2025
Copy link

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants