vision: add set_endpoint sample #1113
Conversation
googlebot
added
the
cla: yes
davidcavazos
force-pushed
the
vision_set_endpoint
branch
from
a27b16a to
f2db374
Compare
| GcsImageUri: "gs://cloud-samples-data/vision/text/screen.jpg", | ||
| }, | ||
| } | ||
| texts, err := client.DetectTexts(ctx, image, nil, 1) |
There was a problem hiding this comment.
Does the output of this change based on the endpoint? Is there a more direct way we can test the endpoint was actually set?
There was a problem hiding this comment.
I don't think the output changes, this is what they're doing in the canonical
There was a problem hiding this comment.
@nnegrey do you know if there is a more direct way to test if the endpoint was actually used? Or is it completely transparent for users?
There was a problem hiding this comment.
Not that I know of for this API, you can pass an invalid endpoint and get an error. But no resource is created.
Natural Language for example has a different set of endpoints they support as documented here: https://cloud.google.com/natural-language/docs/locations
There was a problem hiding this comment.
Could we remove this portion of the test if it's not testing the sample? Or is it needed to make sure it still works after changing the endpoint?
There was a problem hiding this comment.
Mostly to just verify the endpoint works.
There was a problem hiding this comment.
@tbpg how do you feel about this? Would you still want to change anything or should we go ahead and merge?
There was a problem hiding this comment.
In the test, you could set the endpoint to a dummy gRPC server.
(But I think this is good enough.)
davidcavazos
force-pushed
the
vision_set_endpoint
branch
4 times, most recently
from
990bfc3 to
6723252
Compare
|
@tbpg do you think this is ready? |
davidcavazos
force-pushed
the
vision_set_endpoint
branch
from
6723252 to
109421a
Compare
|
Ping me when this is merged so I can add it to the docs. Thanks. |
| GcsImageUri: "gs://cloud-samples-data/vision/text/screen.jpg", | ||
| }, | ||
| } | ||
| texts, err := client.DetectTexts(ctx, image, nil, 1) |
davidcavazos
force-pushed
the
vision_set_endpoint
branch
from
507a850 to
cb9d880
Compare
davidcavazos
force-pushed
the
vision_set_endpoint
branch
from
cb9d880 to
9c45a5d
Compare
|
@tbpg Can we merge this if you think it's ready? (I'm not authorized to merge) |
|
Will wait for Kokoro then merge. Thanks! |
|
Test failure is unrelated. Merging. |
Adding code sample for vision to set a custom endpoint.
Python canonical: GoogleCloudPlatform/python-docs-samples#2569