Skip to content

Conversation

@theacodes
Copy link

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 6, 2016
@waprin
Copy link
Contributor

waprin commented Jan 7, 2016

Hmm I had actually done it this way for Django then changed it to one file. I think it's simpler to just have one file, the typical user changes it once on their end and then they're done. With the template files ehre I like how your git status is clean, but the end-user still has to change config.py anyway. It's kind of bikeshedding a trivial issue, if you want it this way go ahead and merge, I still lean against it and I'm curious your expanded thoughts on it.

@theacodes
Copy link
Author

I can leave it as one file, that's fine. I agree we should be consistent - we should have config.tmpl.py if we're going to do this. Will update.

@theacodes
Copy link
Author

Updated, take another look when you get a chance.

@waprin
Copy link
Contributor

waprin commented Jan 21, 2016

lgtm

theacodes pushed a commit that referenced this pull request Jan 21, 2016
Making yaml files templates, updating readme and makefile.
@theacodes theacodes merged commit 5b5c185 into master Jan 21, 2016
@theacodes theacodes deleted the kubernetes-updates branch January 21, 2016 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants