-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reference to 'bookshelf' in background processing. #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Nov 22, 2019
dzlier-gcp
added
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Nov 22, 2019
kokoro-team
removed
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Nov 22, 2019
dzlier-gcp
force-pushed
the
master
branch
7 times, most recently
from
November 25, 2019 19:33
abbae57
to
1207d94
Compare
dzlier-gcp
added
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Nov 25, 2019
kokoro-team
removed
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Nov 25, 2019
dzlier-gcp
force-pushed
the
master
branch
8 times, most recently
from
November 25, 2019 21:48
ca401e0
to
2fa6d24
Compare
dzlier-gcp
added
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Nov 25, 2019
kokoro-team
removed
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Nov 25, 2019
dzlier-gcp
force-pushed
the
master
branch
2 times, most recently
from
November 25, 2019 22:30
8fe45ef
to
42cf860
Compare
dzlier-gcp
commented
Nov 25, 2019
echo "******** build everything ********" | ||
cd github/getting-started-java | ||
mvn -B --fail-at-end -q clean verify | grep -E -v "(^\[INFO\] Download|^\[INFO\].*skipping)" | ||
|
||
echo "******** Deploy to prod *******" | ||
cd appengine-standard-java8 | ||
|
||
export GOOGLE_CLOUD_PROJECT=java-docs-samples-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI removed this because it's duplicated from above.
kurtisvg
previously approved these changes
Nov 26, 2019
@@ -46,6 +47,7 @@ | |||
*/ | |||
@RunWith(JUnit4.class) | |||
@SuppressWarnings("checkstyle:abbreviationaswordinname") | |||
@Ignore("Issue #498") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the link (or at least reference it as getting-started-java #498)
lesv
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 9, 2019
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Dec 9, 2019
lesv
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.