Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to 'bookshelf' in background processing. #497

Merged
merged 4 commits into from
Jan 14, 2020

Conversation

dzlier-gcp
Copy link
Member

No description provided.

@dzlier-gcp dzlier-gcp requested review from kurtisvg and a team November 22, 2019 18:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2019
@dzlier-gcp dzlier-gcp added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 22, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 22, 2019
@dzlier-gcp dzlier-gcp added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 25, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 25, 2019
@dzlier-gcp dzlier-gcp added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 25, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 25, 2019
echo "******** build everything ********"
cd github/getting-started-java
mvn -B --fail-at-end -q clean verify | grep -E -v "(^\[INFO\] Download|^\[INFO\].*skipping)"

echo "******** Deploy to prod *******"
cd appengine-standard-java8

export GOOGLE_CLOUD_PROJECT=java-docs-samples-testing
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI removed this because it's duplicated from above.

kurtisvg
kurtisvg previously approved these changes Nov 26, 2019
@@ -46,6 +47,7 @@
*/
@RunWith(JUnit4.class)
@SuppressWarnings("checkstyle:abbreviationaswordinname")
@Ignore("Issue #498")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the link (or at least reference it as getting-started-java #498)

@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 9, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 9, 2019
@lesv lesv merged commit 5fb5cdc into GoogleCloudPlatform:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants