Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @google-cloud/discoveryengine to v2 #1913

Conversation

renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@google-cloud/discoveryengine (source) ^1.4.1 -> ^2.0.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Release Notes

googleapis/google-cloud-node (@​google-cloud/discoveryengine)

v2.0.1

Bug Fixes
  • [Many APIs] await/catch promises, and update listOperationsAsync return type (#​6185) (ab30412)

v2.0.0

⚠ BREAKING CHANGES
Features
  • [Many APIs] add request/response debug logging to gapics (afcb5c0)
Miscellaneous Chores

v1.14.0

Features
  • [discoveryengine] promote search tuning service to v1 (#​5655) (f4072a0)

Configuration

📅 Schedule: Branch creation - "* * 1 */3 *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team as a code owner April 1, 2025 09:54
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the @google-cloud/discoveryengine dependency from version ^1.4.1 to ^2.0.0. This includes updating the package-lock.json file to reflect the new version and its transitive dependencies. The update includes breaking changes, such as upgrading to Node 18, as well as new features and bug fixes.

Highlights

  • Dependency Update: The core change is updating the @google-cloud/discoveryengine dependency to version 2.0.0.
  • Node.js Version Upgrade: The update requires upgrading to Node.js version 18 or higher due to breaking changes in the new version of the dependency.
  • Transitive Dependency Updates: Several transitive dependencies, such as @grpc/grpc-js, google-gax, protobufjs, and others, are also updated to their latest compatible versions.

Changelog

Click here to see the changelog
  • gemini/sample-apps/genwealth/api/package-lock.json
    • Updates @google-cloud/discoveryengine from version 1.13.0 to 2.0.1.
    • Updates google-gax from version 4.0.3 to 5.0.1-rc.0.
    • Updates @grpc/grpc-js from version 1.10.11 to 1.13.2.
    • Adds license information to @grpc/proto-loader, @js-sdsl/ordered-map, @protobufjs/*.
    • Updates @types/long from version 4.0.2 to 5.0.0.
    • Adds data-uri-to-buffer, fetch-blob, and formdata-polyfill as new dependencies.
    • Updates proto3-json-serializer from version 2.0.1 to 3.0.0.
    • Updates protobufjs from version 7.2.6 to 7.4.0.
    • Adds web-streams-polyfill as a new dependency.
  • gemini/sample-apps/genwealth/api/package.json
    • Updates @google-cloud/discoveryengine from version ^1.4.1 to ^2.0.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A lockfile's a coder's friend,
Dependencies it will tend.
Ensuring all,
Won't suddenly fall,
And builds continue 'til the end.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates the @google-cloud/discoveryengine dependency to version 2.0.0. The update includes breaking changes, such as upgrading to Node 18, and new features like request/response debug logging. The changes primarily involve updating the package-lock.json and package.json files to reflect the new dependency version and its transitive dependencies.

Merge Readiness

The pull request updates a dependency, and the changes appear to be straightforward version updates in the package.json and package-lock.json files. Given the Automerge: Enabled status, it seems the maintainers have confidence in Renovate's ability to handle these updates. However, since the update includes breaking changes (Node 18 upgrade), it's crucial to ensure the application is compatible with Node 18 before merging. I am unable to approve the pull request in any circumstance, and that users should have others review and approve this code before merging. Since there are no critical or high severity issues, I would recommend that the pull request can be merged after verifying compatibility with Node 18.

@renovate-bot renovate-bot force-pushed the renovate/google-cloud-discoveryengine-2.x branch 3 times, most recently from e0d0923 to 37a2b38 Compare April 2, 2025 15:38
@renovate-bot renovate-bot force-pushed the renovate/google-cloud-discoveryengine-2.x branch from 37a2b38 to b2bea74 Compare April 2, 2025 15:41
@holtskinner holtskinner closed this Apr 2, 2025
Copy link

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 2.x releases. But if you manually upgrade to 2.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot renovate-bot deleted the renovate/google-cloud-discoveryengine-2.x branch April 2, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants