Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing-on-gke enhancements] remove mash dependency #2547

Open
wants to merge 2 commits into
base: garnitin/add-gke-load-testing/upload-outputs-to-gsheet
Choose a base branch
from
Open

[testing-on-gke enhancements] remove mash dependency #2547

wants to merge 2 commits into from

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Oct 3, 2024 •
edited
Loading

Description

Replace mash with monitoring-api everywhere

Purposes:

  • Consistent behavior across all machines
  • Monitoring API has faster runtime than mash.
  • Monitoring API is supported on GCE VM too.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle marked this pull request as ready for review October 3, 2024 07:40
@gargnitingoogle gargnitingoogle requested review from Tulsishah and a team as code owners October 3, 2024 07:40
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from a998865 to ed56ec3 Compare October 3, 2024 17:47
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch 2 times, most recently from 3124adf to 3597a49 Compare October 3, 2024 19:23
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from d50d8d8 to e6a68ea Compare October 4, 2024 05:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 3597a49 to 0e196fe Compare October 4, 2024 05:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 0e196fe to ce3610e Compare October 4, 2024 10:05
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from e6a68ea to d074035 Compare October 7, 2024 10:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from ce3610e to d89519e Compare October 7, 2024 10:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from d074035 to cc74d73 Compare October 7, 2024 10:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from d89519e to c84442d Compare October 7, 2024 10:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from cc74d73 to 80a4844 Compare October 7, 2024 10:29
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from c84442d to ed644a8 Compare October 7, 2024 10:29
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 80a4844 to a60dfc7 Compare October 9, 2024 05:58
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from ed644a8 to 6afa2b2 Compare October 9, 2024 05:58
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from a60dfc7 to 5894807 Compare October 9, 2024 05:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 6afa2b2 to ea03f92 Compare October 9, 2024 05:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 5894807 to 6785cc0 Compare October 9, 2024 07:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from ea03f92 to b60a1b0 Compare October 9, 2024 07:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 6785cc0 to c46b3d2 Compare October 9, 2024 07:43
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from b60a1b0 to 679eb61 Compare October 9, 2024 07:43
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from c46b3d2 to a6c8c11 Compare October 9, 2024 07:50
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 679eb61 to e563cf6 Compare October 9, 2024 07:50
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from a6c8c11 to 37cf702 Compare October 10, 2024 06:34
@gargnitingoogle gargnitingoogle mentioned this pull request Oct 11, 2024
Merged
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 34a59e2 to 8cc66f7 Compare October 14, 2024 02:55
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from ebf7995 to 725d799 Compare October 14, 2024 02:55
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 8cc66f7 to ebb53c9 Compare October 15, 2024 11:42
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 725d799 to 2eab9ca Compare October 15, 2024 11:42
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from ebb53c9 to c63a326 Compare October 18, 2024 05:42
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 2eab9ca to 7efec85 Compare October 18, 2024 05:42
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from c63a326 to 5d72dd9 Compare October 21, 2024 05:11
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 7efec85 to 4793bd7 Compare October 21, 2024 05:11
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 5d72dd9 to a39827c Compare October 22, 2024 05:08
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 4793bd7 to 1c58646 Compare October 22, 2024 05:08
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from a39827c to 62a0d81 Compare October 23, 2024 10:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 1c58646 to aa0a5cf Compare October 23, 2024 10:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 62a0d81 to c83fb2b Compare October 24, 2024 04:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from aa0a5cf to c5db9a1 Compare October 24, 2024 04:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from c83fb2b to 9331486 Compare October 25, 2024 04:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from c5db9a1 to f398524 Compare October 25, 2024 04:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 9331486 to fba55c3 Compare October 30, 2024 10:09
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from f398524 to 0da415b Compare October 30, 2024 10:09
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from fba55c3 to a8bf35d Compare November 4, 2024 04:32
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 0da415b to 4d16cb5 Compare November 4, 2024 04:32
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from a8bf35d to d8e5088 Compare November 6, 2024 06:17
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 4d16cb5 to ea7fd6a Compare November 6, 2024 06:17
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from d8e5088 to 3b84351 Compare November 7, 2024 06:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from ea7fd6a to e82046e Compare November 7, 2024 06:18
@gargnitingoogle
Replace mash with monitoring-api everywhere
c9b2b6a 
Purposes.
* Consistent behavior across all machines
* Monitoring API has faster runtime than mash.
* Monitoring API is supported on GCE VM too.
@gargnitingoogle
fix some var names
29ec670
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 3b84351 to 7fa62f4 Compare November 8, 2024 06:19
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from e82046e to 29ec670 Compare November 8, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethiay sethiay sethiay left review comments

@kislaykishore kislaykishore kislaykishore approved these changes

@Tulsishah Tulsishah Awaiting requested review from Tulsishah Tulsishah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gargnitingoogle @kislaykishore @sethiay