Skip to content

Conversation

mtraver
Copy link
Contributor

@mtraver mtraver commented Mar 8, 2021

No description provided.

@mtraver mtraver requested review from asriniva, di and grant March 8, 2021 21:45
@google-cla google-cla bot added the cla: yes label Mar 8, 2021
@mtraver
Copy link
Contributor Author

mtraver commented Mar 8, 2021

Unit tests pass but coverage is at 99.17%.

Lint says:

lint run-test: commands[1] | isort -rc -c src tests setup.py conftest.py
ERROR: /home/runner/work/functions-framework-python/functions-framework-python/src/functions_framework/convert.py Imports are incorrectly sorted and/or formatted.
ERROR: /home/runner/work/functions-framework-python/functions-framework-python/src/functions_framework/__init__.py Imports are incorrectly sorted and/or formatted.
ERROR: /home/runner/work/functions-framework-python/functions-framework-python/tests/test_convert.py Imports are incorrectly sorted and/or formatted.
/home/runner/work/functions-framework-python/functions-framework-python/.tox/lint/lib/python3.9/site-packages/isort/main.py:1133: UserWarning: W0501: The following deprecated CLI flags were used and ignored: -rc!
  warn(
/home/runner/work/functions-framework-python/functions-framework-python/.tox/lint/lib/python3.9/site-packages/isort/main.py:1137: UserWarning: W0500: Please see the 5.0.0 Upgrade guide: https://pycqa.github.io/isort/docs/upgrade_guides/5.0.0/
  warn(
ERROR: InvocationError for command /home/runner/work/functions-framework-python/functions-framework-python/.tox/lint/bin/isort -rc -c src tests setup.py conftest.py (exited with code 1)

@mtraver
Copy link
Contributor Author

mtraver commented Mar 8, 2021

Ok, all checks pass! Yay!

Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🥳

Please look at the review comments – there are some requested minor changes.
No major blocking comments, so approving. LMK if any comments could be clarified.

@mtraver mtraver merged commit eb6761e into master Mar 9, 2021
@mtraver mtraver deleted the event-conversion branch March 9, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants