feat: configure the proxy with environment variables #1514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I apologize for the size of this PR -- the bulk of the diff is from all the new tests. The new tests ensure that each flag may be set with a corresponding environment variable. In spite of the line count, the actual change here is quite small. |
hessjcg
approved these changes
Oct 31, 2022
Collaborator
hessjcg
left a comment
hessjcg
left a comment
There was a problem hiding this comment.
LGTM.
See comments on one optional change that could make the test cases easier to read.
| } | ||
|
|
||
| // pointer returns a pointer to v | ||
| func pointer[T any](v T) *T { |
kurtisvg
suggested changes
Oct 31, 2022
kurtisvg
approved these changes
Nov 7, 2022
enocom
force-pushed
the
config-from-env
branch
from
3cdeae3 to
2eba461
Compare
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Dec 8, 2022
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225.