Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better service account outputs in project module #82

Merged
merged 5 commits into from
Jun 1, 2020

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented May 30, 2020

This change rationalizes the way robot and default service accounts are exposed in the project module's outputs:

  • all service accounts are exposed via a single service_accounts output
  • the general/legacy service robot is exposed in service_accounts.cloud_services
  • per-service robots are exposed in service_accounts.robots, eg service_accounts.robots.container-engine
  • default service accounts are exposed in service_accounts.default, eg service_accounts.default.compute

Adding extra robot service accounts is done via the local.service_accounts_robot_services variable in the service_accounts.tf file which has been added in this PR.

@ludoo ludoo requested a review from drebes May 30, 2020 17:14
@ludoo
Copy link
Collaborator Author

ludoo commented Jun 1, 2020

@drebes given that you're OOO for a while I'm merging this. :) Feel free to bug me about it of course when you come back.

@ludoo ludoo merged commit 778362c into master Jun 1, 2020
@ludoo ludoo deleted the ludo-project-changes branch June 1, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant