Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for locality policies to net-lb-app-ext module #2898

Merged

Conversation

jacklever-hub24
Copy link
Contributor

@jacklever-hub24 jacklever-hub24 commented Feb 15, 2025

This PR fixes the missing locality_lb_policy/policies fields and blocks missing from the net-lb-app-ext module in CFF. It has two validations to prove correctness of incoming arguments but needs an additional test written to validate the correctness (test-plan-llp.yaml).


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

** Upgrade Notes **

`modules/net-lb-app-ext`: Adds the two missing fields for locality_lb_policy and locality_lb_policies with field and block set, validation for both and tests.

@ludoo
Copy link
Collaborator

ludoo commented Feb 15, 2025

Thanks for this. Can you sign the CLA?

@jacklever-hub24
Copy link
Contributor Author

Fixes #2882

@ludoo ludoo changed the title Locality lb policy fix 2882 Add support for locality policies to net-lb-app-ext module Feb 15, 2025
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped a couple nits, then this is good to go. Thanks! :)

@jacklever-hub24
Copy link
Contributor Author

I've had to revert one of the null checks as it failed the tests. line 169 - backend_service.locality_lb_policy == null ? true :

@ludoo ludoo enabled auto-merge (squash) February 18, 2025 06:20
@ludoo ludoo merged commit a8d7d40 into GoogleCloudPlatform:master Feb 18, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants