Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipv6 and align loadbalancer address types #2883

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Feb 12, 2025

Follow up fix for #2879 (.IP Version and IP Address cannot be specified at the same time)

API returns:

Error: Error creating GlobalForwardingRule: googleapi: Error 400: Invalid value for field \'resource.ipVersion\': \'IPV4\'. IP Version and IP Address cannot be specified at the same time., invalid

  with module.glb-test-0.google_compute_global_forwarding_rule.default[""],
  on fabric/modules/net-lb-app-ext/main.tf line 44, in resource "google_compute_global_forwarding_rule" "default":
  44: resource "google_compute_global_forwarding_rule" "default" {

Add support for __missing__ when testing for plan values.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Upgrade Notes

modules/net-lb-ext: forwarding_rules_config.ip_version was renamed to forwarding_rules_config.ipv6 and its type is now bool
modules/net-lb-int: forwarding_rules_config.ip_version was renamed to forwarding_rules_config.ipv6 and its type is now bool

@wiktorn wiktorn added incompatible change Pull request that breaks compatibility with previous version breaks:modules Breaking changes in a module interface or resources. labels Feb 12, 2025
@wiktorn wiktorn force-pushed the wiktorn-fix-lb-ipv6 branch from 7d019ea to f59f4a7 Compare February 12, 2025 10:49
@wiktorn wiktorn force-pushed the wiktorn-fix-lb-ipv6 branch 2 times, most recently from 5289a05 to bded5b4 Compare February 12, 2025 10:59
@wiktorn wiktorn enabled auto-merge (rebase) February 12, 2025 11:05
@wiktorn wiktorn force-pushed the wiktorn-fix-lb-ipv6 branch 2 times, most recently from 31edd20 to 9f782fc Compare February 12, 2025 11:20
@wiktorn wiktorn force-pushed the wiktorn-fix-lb-ipv6 branch from 9f782fc to e196132 Compare February 12, 2025 11:49
@wiktorn wiktorn merged commit 62665f2 into master Feb 12, 2025
18 checks passed
@wiktorn wiktorn deleted the wiktorn-fix-lb-ipv6 branch February 12, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks:modules Breaking changes in a module interface or resources. incompatible change Pull request that breaks compatibility with previous version on:blueprints on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants