Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules/compute-vm end-to-end tests and fixes #2819

Merged
merged 1 commit into from
Jan 16, 2025
Merged

modules/compute-vm end-to-end tests and fixes #2819

merged 1 commit into from
Jan 16, 2025

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Jan 16, 2025

Add E2E tests and fix examples:

  • boot disk image configuration fixes
  • updated docs for alias IPs and gVNIC
  • added IAM grant and note about permissions for service agent for Instance Schedules
  • use Confidential Compute compatible image and instance type

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn wiktorn changed the base branch from master to qa-net January 16, 2025 09:54
@wiktorn wiktorn changed the base branch from qa-net to master January 16, 2025 09:54
@wiktorn wiktorn merged commit 10cc3d8 into master Jan 16, 2025
18 checks passed
@wiktorn wiktorn deleted the wiktorn-compute-vm-e2e branch January 16, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiktorn @ludoo @juliocc