Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top level folder factory support for automation SA IAM #2818

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

sruffilli
Copy link
Collaborator

@sruffilli sruffilli commented Jan 15, 2025

This PR adds the ability to refer to the automation service account when creating role bindings in the top-level-folder factory.

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice :)

@sruffilli
Copy link
Collaborator Author

Latest change fixes a pre-existing bug in the definition of iam_bindings and iam_bindings_additive in the top-level-folder module.

@sruffilli sruffilli enabled auto-merge (squash) January 16, 2025 08:59
@sruffilli sruffilli disabled auto-merge January 16, 2025 09:01
@ludoo ludoo changed the base branch from master to fast-dev January 16, 2025 09:01
@sruffilli sruffilli merged commit 8b31a00 into fast-dev Jan 16, 2025
20 checks passed
@sruffilli sruffilli deleted the sruffilli/top-level-folder-sa-iam branch January 16, 2025 09:33
karpok78 pushed a commit to karpok78/cloud-foundation-fabric that referenced this pull request Jan 19, 2025
…atform#2818)

* Top level folder factory support for automation SA IAM

* Fixes iam_bindings and iam_bindings_additive for top-level-folder

---------

Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants