Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hierarchical namespace support to GCS module #2712

Merged
merged 4 commits into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
juliocc committed Nov 18, 2024
commit 9de0f9053166d03f7df924541ef49662a1249b75
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2023 Google LLC
# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -383,7 +383,6 @@ values:
description: Terraform managed.
enable_cdn: null
failover_policy: []
iap: []
load_balancing_scheme: EXTERNAL
locality_lb_policy: null
name: test-nlb
Expand Down Expand Up @@ -491,4 +490,4 @@ counts:
google_compute_region_backend_service: 2
google_compute_region_health_check: 1
modules: 8
resources: 20
resources: 20
1 change: 0 additions & 1 deletion tests/modules/cloudsql_instance/examples/simple.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ values:
advanced_machine_features: []
availability_type: ZONAL
collation: null
data_cache_config: []
database_flags: []
deletion_protection_enabled: false
deny_maintenance_period: []
Expand Down
5 changes: 2 additions & 3 deletions tests/modules/dns/examples/peering-zone.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2023 Google LLC
# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -18,7 +18,6 @@ values:
- enable_logging: false
description: Terraform managed.
dns_name: .
dnssec_config: []
force_destroy: false
forwarding_config: []
labels: null
Expand All @@ -39,4 +38,4 @@ values:
counts:
google_dns_managed_zone: 1
modules: 1
resources: 1
resources: 1
5 changes: 2 additions & 3 deletions tests/modules/dns/examples/routing-policies.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2023 Google LLC
# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -18,7 +18,6 @@ values:
- enable_logging: false
description: Terraform managed.
dns_name: test.example.
dnssec_config: []
force_destroy: false
forwarding_config: []
labels: null
Expand Down Expand Up @@ -109,4 +108,4 @@ counts:
google_dns_managed_zone: 1
google_dns_record_set: 4
modules: 4
resources: 12
resources: 12
2 changes: 0 additions & 2 deletions tests/modules/gke_hub/examples/full.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,8 @@ values:
ephemeral_storage_config: []
ephemeral_storage_local_ssd_config: []
fast_socket: []
gcfs_config: []
gvnic: []
host_maintenance_policy: []
kubelet_config: []
linux_node_config: []
local_nvme_ssd_block_config: []
node_group: null
Expand Down
2 changes: 0 additions & 2 deletions tests/modules/net_cloudnat/examples/hybrid.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ values:
project: project-id
region: europe-west8
module.vpc1-nat.google_compute_router_nat.nat:
drain_nat_ips: null
enable_dynamic_port_allocation: true
enable_endpoint_independent_mapping: false
icmp_idle_timeout_sec: 30
Expand All @@ -30,7 +29,6 @@ values:
filter: ALL
name: vpc1-nat
nat_ip_allocate_option: null
nat_ips: null
project: project-id
region: europe-west8
router: vpc1-nat-nat
Expand Down
Loading