Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling network security stage #2701

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Allow disabling network security stage #2701

merged 3 commits into from
Nov 17, 2024

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Nov 16, 2024

This PR:

  • Removes some incorrect bindings that were failing when the security stage is disabled.
  • Some potential errors being masked by try()s.
  • Binding to an non-existing network_firewall_policies_viewer custom role.

@juliocc
Copy link
Collaborator Author

juliocc commented Nov 16, 2024

The test failure is expected. We where previously assigning the network_firewall_policies_admin role always, but it's only needed if network_security is enabled.

So we either extend the test to enable network_security or we keep it as is and just remove that binding from the inventory.

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments, nsec != security

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for being patient lol

@ludoo ludoo changed the title Allow disabling security stage Allow disabling network security stage Nov 17, 2024
@juliocc juliocc merged commit 1fc5e90 into fast-dev Nov 17, 2024
18 checks passed
@juliocc juliocc deleted the jccb/stage2-fixes branch November 17, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants