Allow customizable prefix in net-vpc module PSA configs

[ludoo]

Fixes #2529

[juliocc]

lgtm!

[intotecho]

Really appreciate this fix as it saved having to delete and rebuild network elements in use.
However, my plan is still trying to replace a psa_connection[0] with .psa_connection["servicenetworking.googleapis.com"] .

Config

module "host_network" {
  source = "../cloud-foundation-fabric/modules/net-vpc"
  project_id                      = var.network_project_id
  auto_create_subnetworks         = false
  name                            = var.network_name
  delete_default_routes_on_create = true
  description                     = var.description
  shared_vpc_host                 = var.shared_vpc
  subnets                         = var.subnets
  subnets_proxy_only              = var.subnets_proxy_only
  shared_vpc_service_projects     = var.service_project_ids
  #subnet_iam_additive             = var.subnet_iam_permissions
  psa_configs = [{
    ranges = { range-a = "10.200.0.0/16" }
    range_prefix = ""
  }]
}

Plan

module....host_network.google_service_networking_connection.psa_connection[0] will be destroyed
  # (because resource does not use count)
  - resource "google_service_networking_connection" "psa_connection" {
      - id                      = "projects%PROJECT%2Fglobal%2Fnetworks%2Fgeo-nw-uat:servicenetworking.googleapis.com" -> null
      - network                 = "projects/PROJECT/global/networks/geo-nw-uat" -> null
      - peering                 = "servicenetworking-googleapis-com" -> null
      - reserved_peering_ranges = [
          - "range-a",
        ] -> null
      - service                 = "servicenetworking.googleapis.com" -> null
    }

Apply

Unable to remove Service Networking Connection, err: Error waiting for Delete Service Networking Connection: Error code 9, message: Failed to delete connection; Producer services (e.g. CloudSQL, Cloud Memstore, etc.) are still using this connection.

I am not sure how to proceed?

[juliocc]

Can you share the full plan? I think that one can be fixed with a moved block.

[intotecho]

I was able to resolve this with

terraform state mv module.my_network.google_service_networking_connection.psa_connection[0]   module.my_network.google_service_networking_connection.psa_connection[\"servicenetworking.googleapis.com\"]