FAST: IAM cleanups to reflect PF changes #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good points, I also tackle them in the resman-ng branch, if you're not in a hurry can we discuss this holistically next Mon? :) |
ludoo
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR retrospect-fixes a few IAM leftovers on the FAST networking stages.
In particular:
service_project_network_admincustom role is assigned to the PF SA by 1-resman at folder level, so the project-level assignment done by 2-net is not neededroles/dns.adminis not required anymore since the PF doesn't deal with DNS management anymore (even though it could arguably be configured to assign DNS roles to other principals)