Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version check #1950

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Dec 25, 2023

Add version check to Linting workflow.

Failed run


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@github-actions github-actions bot added on:tools New or changed tool on:modules labels Dec 25, 2023
@wiktorn wiktorn force-pushed the wiktorn-version-check branch from 3ca317f to 3e33e47 Compare December 25, 2023 08:24
@wiktorn wiktorn force-pushed the wiktorn-version-check branch from 3e33e47 to 3308334 Compare December 25, 2023 08:25
@wiktorn wiktorn marked this pull request as ready for review December 25, 2023 08:27
@wiktorn wiktorn enabled auto-merge (rebase) December 26, 2023 08:54
@wiktorn wiktorn merged commit 70a94ed into GoogleCloudPlatform:master Dec 27, 2023
9 checks passed
@juliocc
Copy link
Collaborator

juliocc commented Dec 29, 2023

@wiktorn can you add a similar check to tools/lint.sh?

@wiktorn wiktorn mentioned this pull request Dec 29, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on:tools New or changed tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants