Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to end tests for GCS #1864

Merged
merged 7 commits into from
Nov 16, 2023
Merged

End to end tests for GCS #1864

merged 7 commits into from
Nov 16, 2023

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Nov 16, 2023

  • add end to end tests for examples in GCS module
  • fix KMS module bug
  • do not skip tftest skip tests in end-to-end tests, just don't add e2e tag

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

ludoo
ludoo approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep these coming Wiktor :)

@wiktorn wiktorn merged commit 4343a57 into master Nov 16, 2023
@wiktorn wiktorn deleted the wiktorn-gcs-examples branch November 16, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:FAST on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @ludoo