Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FQDN Network Policy feature on GKE Cluster #1732

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

luigi-bitonti
Copy link
Contributor

Added the possibily to enable FQDN Network Policy feature on standard GKE Cluster

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@danielmarzini
Copy link
Collaborator

Hey @luigi-bitonti thanks for the PR, can you also add the change on the autopilot-module?

@luigi-bitonti
Copy link
Contributor Author

Hey @luigi-bitonti thanks for the PR, can you also add the change on the autopilot-module?

Hi Daniel, I didn't do it because GCP doc (https://cloud.google.com/kubernetes-engine/docs/how-to/fqdn-network-policies#enable_fqdn_network_policy_in_a_new_cluster) said that "You can't enable this feature when you create a new Autopilot cluster", but only on an existing one.
Do you want the feature anyway?

@danielmarzini
Copy link
Collaborator

Hey @luigi-bitonti thanks for the PR, can you also add the change on the autopilot-module?

Hi Daniel, I didn't do it because GCP doc (https://cloud.google.com/kubernetes-engine/docs/how-to/fqdn-network-policies#enable_fqdn_network_policy_in_a_new_cluster) said that "You can't enable this feature when you create a new Autopilot cluster", but only on an existing one. Do you want the feature anyway?

It's a good catch, I didn't see that we this one. So actually, during the preview, we can use it on existing clusters only, that would drive us to this in two steps. I think, but @juliocc keep me honest, I'd go ahead with Standard only and open an issue the integrate this as soon as it reaches the GA stage. @juliocc wdyt?

@juliocc
Copy link
Collaborator

juliocc commented Oct 5, 2023

I'm okay not adding the flag to autopilot as long as we open an issue to keep track of it.

@juliocc juliocc merged commit bb76878 into GoogleCloudPlatform:master Oct 6, 2023
@luigi-bitonti luigi-bitonti deleted the new_gke_feature branch October 6, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants