-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added FQDN Network Policy feature on GKE Cluster #1732
Added FQDN Network Policy feature on GKE Cluster #1732
Conversation
e6b5250
to
d95808a
Compare
Hey @luigi-bitonti thanks for the PR, can you also add the change on the autopilot-module? |
Hi Daniel, I didn't do it because GCP doc (https://cloud.google.com/kubernetes-engine/docs/how-to/fqdn-network-policies#enable_fqdn_network_policy_in_a_new_cluster) said that "You can't enable this feature when you create a new Autopilot cluster", but only on an existing one. |
It's a good catch, I didn't see that we this one. So actually, during the preview, we can use it on existing clusters only, that would drive us to this in two steps. I think, but @juliocc keep me honest, I'd go ahead with Standard only and open an issue the integrate this as soon as it reaches the GA stage. @juliocc wdyt? |
I'm okay not adding the flag to autopilot as long as we open an issue to keep track of it. |
433821d
to
5d5ac66
Compare
Added the possibily to enable FQDN Network Policy feature on standard GKE Cluster
Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py