Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apigee module fix try #1717

Merged
merged 6 commits into from
Oct 1, 2023
Merged

Apigee module fix try #1717

merged 6 commits into from
Oct 1, 2023

Conversation

apichick
Copy link
Collaborator

Fixed problem in apigee module with try when attachments were being created

Checklist

I applicable, I acknowledge that I have:

  • [X ] Read the contributing guide
  • Ran terraform fmt on all modified files
  • [ X] Regenerated the relevant README.md files using tools/tfdoc.py
  • [X ] Made sure all relevant tests pass

@apichick apichick enabled auto-merge September 29, 2023 15:09
juliocc
juliocc previously approved these changes Sep 29, 2023
View reviewed changes
g-greatdevaks
g-greatdevaks approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@g-greatdevaks g-greatdevaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested the different flows for Instance Attachment, Environment Group Attachment, referencing of manually created resources, etc.

@apichick apichick merged commit f0f6996 into GoogleCloudPlatform:master Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

@g-greatdevaks g-greatdevaks g-greatdevaks approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apichick @juliocc @g-greatdevaks