Support arbitrary precision input in cw_convert_base for supported radix.
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arotenberg-google
suggested changes
Jul 19, 2023
There was a problem hiding this comment.
Can we just do a manual conversion? At least for the case where we currently fall back to parseInt, so that we have identical behavior across all bases and not behavior that works for large magnitude integers for some bases and not others.
danieldeleo
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the use of
BigInt(arbitrary precision integer numbers) incw_convert_base.BigIntwill be used for supported radix (2,8,10,16) else the function will default toparseIntwhich can safely represent integer numbers within approximately+/- 2^53.