-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding terraform and tests #371
Changes from 1 commit
d8bc049
2e14dd1
f98521d
8d9234e
c7a5b54
e8ec829
f88db34
c0a930d
4eb7585
8501dfc
fd48691
856c8a3
b172b36
edfd098
6525b7a
7a5018e
cf01080
f38219d
b178a40
3f8f8bc
ec95133
18c178c
67b2671
086428a
7d45fda
fa9bd01
f3c5e20
7308c3c
042d060
4be091d
9c665ae
afe5e2e
232f7c0
2bf70ea
067b4dc
243e9d4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
- Loading branch information
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Line 35 has typo: ame |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,7 @@ The following environemnt variables must be set: | |
* `TABLE_NAME_PUBSUB_TOPIC_ID` ame of P/S topic where this code will publish to | ||
|
||
## bq_backup_create_snapshots | ||
The **bq_backup_create_snapshots** cloud function will submit a BigQuery job to create a snapshot for each table in scope. This cloud function will suffix the snapshot name with the snapshot datetime to guarantee a unique name. It will also calculate and set the expiration time of the snapshot based on seconds_before_expiration. Finally, it will determine the snapshot time based on crontab_format. | ||
The **bq_backup_create_snapshots** Cloud Function will submit a BigQuery job to create a snapshot for each table in scope. This Cloud Function will suffix the snapshot name with the snapshot datetime to guarantee a unique name. It will also calculate and set the expiration time of the snapshot based on seconds_before_expiration. Finally, it will determine the snapshot time based on crontab_format. | ||
The following environemnt variables must be set: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reword this and line 32 as well since it instructs the user to set an environment variable but the Terraform will actually do this. The following could be an appropriate rewording: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also lines 32 & 39 have typo: environemnt |
||
* `BQ_DATA_PROJECT_ID` id of project used for BQ storage | ||
* `BQ_JOBS_PROJECT_ID` id of project used for BQ compute | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 16 replace Scheduloer with Scheduler