Skip to content

Cloud functions ingest: backfill CLI tool + minor improvements#190

Merged
danieldeleo merged 71 commits intoGoogleCloudPlatform:masterfrom
jaketf:cloud-functions-ingest
Nov 18, 2020
Merged

Cloud functions ingest: backfill CLI tool + minor improvements#190
danieldeleo merged 71 commits intoGoogleCloudPlatform:masterfrom
jaketf:cloud-functions-ingest

Conversation

@jaketf
Copy link

@jaketf jaketf commented Nov 11, 2020

This adds a CLI tool for backfilling notifications or running backfill concurrent invocations to cloud function's main method locally. Improve deafult naming convention regex to support yyyy/mm/dd/hh

TODOs:

  • improve CLI performance with ThreadPools
  • add cli tests
  • restructure tests
  • DRY up pytest fixtures
  • support cloud functions direct storage triggers (no pub/sub)

Jacob Ferriero and others added 8 commits November 17, 2020 10:00
…/main.py

Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
…ckfill.py

Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Jacob Ferriero added 4 commits November 17, 2020 12:29
* use client libraray gsurl parser
* explicitly check kind == "storage#object"
* fix yapf / isort contention / non-determinism
* briefly cache redundant GCS API calls
* naming nits
@jaketf jaketf requested a review from danieldeleo November 17, 2020 21:14
@jaketf
Copy link
Author

jaketf commented Nov 18, 2020

CI is happy now !

@danieldeleo danieldeleo merged commit 7210f43 into GoogleCloudPlatform:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants