Skip to content

Conversation

kritkasahni-google
Copy link
Collaborator

Port Python3 search API plus dependencies.

@shreejad shreejad self-requested a review April 17, 2023 21:45
@ludoch
Copy link
Collaborator

ludoch commented Apr 17, 2023

Ready to merge now? I can merge if OK.

@kritkasahni-google
Copy link
Collaborator Author

@ludoch Checked with Shreeja earlier today and looks like we need to release from https://github.com/GoogleCloudPlatform/appengine-python-standard/tree/1.0.1-rc1? Because I think pre-release was from that branch on Sep2, 2022 [1] ?
I have ported my changes to /1.0.1-rc1 also today and all UTs passing + my sample app continues to work. But I noticed _pb2.py files format is different between main branch[2] and 1.0.1-rc1 branch[3]. I have so far been working from main branch so new _pb2.py files I added for search and its deps[4] follow latest format in main which is different in 1.0.1-rc1 branch. Atm I am investigating to see if the discrepancy in protobufs could cause any issues.

[1] https://github.com/GoogleCloudPlatform/appengine-python-standard/tags
[2] https://github.com/GoogleCloudPlatform/appengine-python-standard/blob/main/src/google/appengine/datastore/datastore_v3_bytes_pb2.py
[3] https://github.com/GoogleCloudPlatform/appengine-python-standard/blob/1.0.1-rc1/src/google/appengine/datastore/datastore_v3_bytes_pb2.py
[4] https://github.com/GoogleCloudPlatform/appengine-python-standard/blob/1.0.1-rc1/src/google/appengine/api/search/search_service_pb2.py

@kritkasahni-google kritkasahni-google merged commit 547a396 into main Apr 18, 2023
shreejad pushed a commit that referenced this pull request Apr 19, 2023
* added search and deps

* added __init__.py in _internal

* added document pb

* remove broken tests; will fix as part of backlog

* .DS_Store banished

* Update tox config to run antlr3 UTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants