[WIP] Add support for logging based on google-cloud-logging#347
[WIP] Add support for logging based on google-cloud-logging#347meltsufin wants to merge 2 commits intoasync-supportfrom
Conversation
appengine-managed-runtime/pom.xml
Outdated
| @@ -31,6 +31,7 @@ | |||
| <properties> | |||
| <maven.build.timestamp.format>yyyyMMddHHmm</maven.build.timestamp.format> | |||
| <appengine.api.version>1.9.40</appengine.api.version> | |||
There was a problem hiding this comment.
This is probably no longer used, but if it is, it should be at least 1.9.48 if not .49
| <properties> | ||
| <maven.build.timestamp.format>yyyyMMddHHmm</maven.build.timestamp.format> | ||
| <appengine.api.version>1.9.40</appengine.api.version> | ||
| <gcloud.api.version>0.8.2-beta-SNAPSHOT</gcloud.api.version> |
There was a problem hiding this comment.
Why are you using the -SNAPSHOT ??
You do need to initialize Cloud Logging and turn on the JUL hook to use it. -- I don't see that here.
There was a problem hiding this comment.
Like Greg mentioned, we don't have a non-snapshot release of it yet.
|
@meltsufin I'm not going to have a chance to run this myself for a few hours. But I'm guessing the problem is that this compat runs with the working directory at $JETTY_BASE rather than in the webapp itself. So your relative path to @lesv the SNAPSHOT is used because the |
|
@gregw It looks like |
|
@meltsufin perhaps we need a PR on google-cloud-logging that will print any exceptions to stderr so we one can better debug logging problems in init? |
|
@gregw Yes, that's a good idea. I also think we need to pull the zone stuff into this PR for now because it sounds like they won't be able to merge that PR and release in a while. |
I'm trying to port over the new logging mechanism to the compat runtime to be used with a custom
logging.propertiesfile, but not having much luck.In my test app, I have this in
webapp\WEB-INF\logging.properties:and
appengine-web.xmlhas this:@gregw This configuration doesn't seem to be working. I only see logs in the
appstream and no sign ofgae_app.login the Stackdriver Logging UI. Any thoughts?