This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Configurable stop time #302#305
Merged
ludoch merged 1 commit intoGoogleCloudPlatform:async-supportfrom Jul 28, 2016
Merged
Conversation
Temporary fix for GoogleCloudPlatform#302 until parameter added to jetty release
| jetty.httpConfig.responseHeaderSize=8192 | ||
| jetty.httpConfig.sendServerVersion=true | ||
| jetty.httpConfig.sendDateHeader=false | ||
| jetty.server.stopTimeout=30000 |
Contributor
There was a problem hiding this comment.
Not commented here, but commented on the one above... jetty9-base/src/main/jetty-base/modules/gae.mod
Any reasons?
Contributor
Author
There was a problem hiding this comment.
There is a default value in the XML of 30s that will be used if the property is not set.
The property is commented out in the jetty9 module because it is following the jetty convention of just documenting with a commented property how to change the default
The property is not commented out in the compat module because it is following the gae-compat convention of being explicit in one place of key values and not relying on jetty defaults.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary fix for #302 until parameter added to jetty release