Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added yaml files for service account and the service #701

Merged

Conversation

gotochkin
Copy link
Contributor

Added yaml files for service account and the service with tags to be used as samples in the documentation.
Also updated tags for the sidecar proxy container yaml to be able it insert it to docs as a sample.

Copy link

conventional-commit-lint-gcf bot commented Aug 26, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

added yaml with tags to be used as samples in docs
@gotochkin gotochkin changed the title Added yaml files for service account and the service chore: added yaml files for service account and the service Aug 26, 2024
@gotochkin gotochkin force-pushed the add-service-gsa-yaml-examples branch from 7f8b496 to 4d959e0 Compare August 26, 2024 13:40
@gotochkin gotochkin marked this pull request as ready for review August 26, 2024 13:45
@gotochkin gotochkin requested a review from a team as a code owner August 26, 2024 13:45
@nancynh
Copy link
Collaborator

nancynh commented Aug 26, 2024

Thank you @gotochkin!

@nancynh nancynh merged commit 6f8ffe1 into GoogleCloudPlatform:main Aug 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants