Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename import, implement attestation, cleanup name #20

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

mchmarny
Copy link
Contributor

Major refactor across the entire project to rename the import to vulnerability and implement the attestation import command.

@mchmarny mchmarny added the enhancement New feature or request label Mar 21, 2023
@mchmarny mchmarny requested a review from taechae March 21, 2023 21:34
taechae
taechae previously approved these changes Mar 21, 2023
@mchmarny mchmarny enabled auto-merge (squash) March 21, 2023 21:36
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #20 (06eec54) into main (4910874) will increase coverage by 0.28%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   53.93%   54.21%   +0.28%     
==========================================
  Files          11       11              
  Lines         981      976       -5     
==========================================
  Hits          529      529              
+ Misses        435      430       -5     
  Partials       17       17              
Flag Coverage Δ
unittests 54.21% <60.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/aactl/cli/attest.go 0.00% <0.00%> (ø)
cmd/aactl/cli/cmd.go 42.00% <ø> (ø)
pkg/attestation/convert.go 0.00% <0.00%> (ø)
pkg/vul/delete.go 0.00% <0.00%> (ø)
pkg/vul/import.go 9.10% <33.34%> (ø)
pkg/attestation/import.go 5.94% <50.00%> (ø)
cmd/aactl/cli/vuln.go 84.22% <100.00%> (ø)
pkg/convert/grype/grype.go 88.47% <100.00%> (ø)
pkg/convert/snyk/snyk.go 93.92% <100.00%> (ø)
pkg/convert/trivy/trivy.go 94.83% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mchmarny mchmarny disabled auto-merge March 21, 2023 21:46
@mchmarny mchmarny merged commit e8fbff7 into main Mar 21, 2023
@mchmarny mchmarny deleted the mchmarny-cli-cmd-rename branch March 21, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants