Skip to content

Governing Rules

Jump to bottom
Kris Hildrum edited this page Feb 25, 2016 · 8 revisions

The governing rules for PerfKitBenchmaker (PKB) are inspired by the Apache Group though they are not the same. One similarity is PKB is run as a meritocracy. The more contributions are made the more rights and responsibilities are earned.

There are five groups of people:

  1. Managers
  2. Committers
  3. Steering committee
  4. Contributors
  5. Users

Managers:

Currently Google is designated as the manager to:

  1. Manage the repo.
  2. Maintain the mailing lists and groups.
  3. Schedule and plan community meetings.
  4. Add committers.
  5. Work with the community to maintain the steering committee.

Committers:

Committers have write access to the GitHub repo. They hold the following responsibilities:

As of December 2015 the following are committers:

  • Google (Cloud Performance team + Google Developer Relations)
  • Rackspace (meteorfox@)
  • Intel (mateusz-blaszkowski@)

New committers are nominated by existing committers and from contributors that have made significant improvements and shown a high bar for quality.

Steering committee:

The steering committee is responsible for resolving disagreements on what benchmarks are included in the standard_set, how the benchmarks in that set are run, how they are configured, and when to remove benchmarks. This committee is the final decider when the community through a vote disagrees. More on voting.

As of December 2015 the following is the Steering committee:

A new steering committee is nominated on an annual basis. Until a new committee is in place the existing one will continue to serve. The next committee will be nominated in February 2016.

Contributors:

Contributors are anyone submitting code to the repo for shared use. They must sign the CLA as explained in the CONTRIBUTING.md file.

Contributors also include those in the community opening issues, suggesting improvements, attending community meetings, and sharing ideas on the group mailing lists.

Users:

Users are anyone using PKB to measure performance. We love users! We hope you contribute your ideas and code.

Voting:

Voting is an extremely important topic and it is the way we as a community decide. Here is the way it works:

  • Any committer, steering committee member, or manager can open a GitHub issue for a vote.
  • The Github issue must detail what is to be voted on: Addition of a benchmark, changes to a benchmark, resolution on a disagreement around design, etc.
  • Committers, Steering committee, and managers then have two weeks to +1, 0 (ignore), or -1 an issue. At the end of two weeks the vote is tallied.
  • If the vote is positive the change is implemented.
  • If the vote is negative it goes to the Steering Committee to resolve. Their vote is final.

Merging Pull Requests

Each pull request (PR) should be reviewed by at least one committer who is not the PR author. After the author has signed the CLA, and the PR has received a "Looks Good To Me" (LGTM) comment from its reviewer, the PR may be merged. Merging the pull request after the LGTM comment is the responsibility of the author if the author is a committer, and the reviewer otherwise.

Clone this wiki locally