-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adding FileFormatConversion template #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding FileFormatConversion template #70
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
a22fd47 to
142725e
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/AvroConverters.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/AvroConverters.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/AvroConverters.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/AvroConverters.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/ParquetConverters.java
Outdated
Show resolved
Hide resolved
...ersion/src/main/java/com/google/cloud/teleport/v2/templates/FileFormatConversionFactory.java
Outdated
Show resolved
Hide resolved
...ersion/src/main/java/com/google/cloud/teleport/v2/templates/FileFormatConversionFactory.java
Outdated
Show resolved
Hide resolved
...at-conversion/src/main/java/com/google/cloud/teleport/v2/templates/FileFormatConversion.java
Outdated
Show resolved
Hide resolved
...ersion/src/main/java/com/google/cloud/teleport/v2/templates/FileFormatConversionFactory.java
Outdated
Show resolved
Hide resolved
...onversion/src/test/java/com/google/cloud/teleport/v2/templates/FileFormatConversionTest.java
Outdated
Show resolved
Hide resolved
142725e to
186352b
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
186352b to
a179763
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
a179763 to
711cebb
Compare
|
Hey @sabhyankar, |
711cebb to
dfa621a
Compare
v2/common/src/main/java/com/google/cloud/teleport/v2/utils/SchemaUtils.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/utils/SchemaUtils.java
Outdated
Show resolved
Hide resolved
sabhyankar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the change to the error message as indicated.
dfa621a to
0d2402c
Compare
sabhyankar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PiperOrigin-RevId: 282385711
* Dml integration (#53) * Added extensive UT Added extensive UT * Cassandra pr bug fixes (#57) * Cassandra Consolidate Unit Test case and Regression testing fixes (#58) * Added Mapping fixes * Added Spoltles fixes * Added Consolidated fixes * Added TODO * Addess Data and Time * Cassandra pr bug fixes (#64) * Handle TypeHandler Parsing issue fixes (#65) Co-authored-by: pawankashyapollion <v-pawan.kumar@ollion.com> * Added Safe handle (#68) * Handle LocalTime For Time Data Type In Cassandra (#69) * Cassandra pr bug fixes (#70) * Handle Timestamp Fixes (#72) * Added Code Combined in a single way * Address The Unwanted Hop * Cassandra pr bug fixes (#75) * Added PR Review Comments * Remove NamesCol Dependecy as spannerTableName is same as In Given Mapping * Added spannerTableId for fetching Mapping * Removed SpannerToID and also Updated Session file with proper structure * Timestamp in milisecond * removed assertNotNull from UT wherever possible * Added Fixes * Added Note Instead of Question * -- review fixes (#78) * Added Bytes to hex to blob conversion * Handling Bytes as Binary encoded As of now * Passing Null Value to Primary Key as well for cassandra * Added UT fixes * Added UT refectoring * Reverse merge confict fixes --------- Co-authored-by: pawankashyapollion <v-pawan.kumar@ollion.com> Co-authored-by: Akash Thawait <aakash@ollion.com>
No description provided.