Adding BigQueryToElasticsearch dynamic template. #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabhyankar
requested changes
Oct 29, 2019
Member
sabhyankar
left a comment
sabhyankar
left a comment
There was a problem hiding this comment.
@chrlarsen - This is looking pretty good overall. Can you take a look at the inline comments. Especially the ones regarding the need for a UDF for this pipeline?
...sticsearch/src/main/java/com/google/cloud/teleport/v2/templates/BigQueryToElasticsearch.java
Outdated
Show resolved
Hide resolved
...sticsearch/src/main/java/com/google/cloud/teleport/v2/templates/BigQueryToElasticsearch.java
Outdated
Show resolved
Hide resolved
...sticsearch/src/main/java/com/google/cloud/teleport/v2/templates/BigQueryToElasticsearch.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/ElasticsearchTransforms.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/ElasticsearchTransforms.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/ElasticsearchTransforms.java
Outdated
Show resolved
Hide resolved
chrlarsen
force-pushed
the
bigquery-to-elasticsearch
branch
3 times, most recently
from
cf7a3b5 to
82d36a5
Compare
Contributor
Author
|
@sabhyankar udf and deadlettering has been removed and other comments have been addressed. Thanks! |
sabhyankar
requested changes
Nov 4, 2019
Member
sabhyankar
left a comment
sabhyankar
left a comment
There was a problem hiding this comment.
Minor nits. Can you resolve, rebase and squash? :)
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/ValueExtractorTransform.java
Outdated
Show resolved
Hide resolved
chrlarsen
force-pushed
the
bigquery-to-elasticsearch
branch
from
82d36a5 to
dcd715a
Compare
chrlarsen
force-pushed
the
bigquery-to-elasticsearch
branch
from
dcd715a to
e17425d
Compare
Contributor
Author
|
@sabhyankar updated, rebased and squashed :) |
sabhyankar
added
the
Google LGTM
ryanmcdowell
pushed a commit
that referenced
this pull request
Nov 6, 2019
PiperOrigin-RevId: 278792316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sabhyankar adding BigQueryToElasticsearch template.