-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 582 - MongoDBtoBigQuery with UDF: ScriptObjectMirror cannot be cast to bson.Document #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polber
added
integration testing
Migration of integration tests to github
MongoDB
labels
Feb 10, 2023
bvolpato
reviewed
Feb 10, 2023
...ecloud/src/test/java/com/google/cloud/teleport/v2/mongodb/templates/MongoDbToBigQueryIT.java
Outdated
Show resolved
Hide resolved
bvolpato
previously approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Added a suggestion but feel free to skip
(BTW Spotless check is failing, please mvn spotless:apply
)
Polber
force-pushed
the
jkinard/582
branch
2 times, most recently
from
February 10, 2023 16:04
5fc2b3f
to
1040138
Compare
bvolpato
previously approved these changes
Mar 8, 2023
bvolpato
added
the
Google LGTM
Approval of a pull request to be merged into the repository
label
Mar 8, 2023
…cast to bson.Document Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Google LGTM
Approval of a pull request to be merged into the repository
integration testing
Migration of integration tests to github
MongoDB
size/M
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #582 by correcting illegal cast to bson.Document in MongoDB templates that utilize UDF's.
Signed-off-by: Jeffrey Kinard jeff@thekinards.com