Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 582 - MongoDBtoBigQuery with UDF: ScriptObjectMirror cannot be cast to bson.Document #588

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Feb 10, 2023

This PR fixes #582 by correcting illegal cast to bson.Document in MongoDB templates that utilize UDF's.

Signed-off-by: Jeffrey Kinard jeff@thekinards.com

@Polber Polber added integration testing Migration of integration tests to github MongoDB labels Feb 10, 2023
@Polber Polber requested a review from bvolpato February 10, 2023 15:33
@Polber Polber self-assigned this Feb 10, 2023
bvolpato
bvolpato previously approved these changes Feb 10, 2023
Copy link
Contributor

@bvolpato bvolpato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a suggestion but feel free to skip

(BTW Spotless check is failing, please mvn spotless:apply)

@theshanbhag
Copy link
Contributor

Hi @Polber @bvolpato can we please merge this?

bvolpato
bvolpato previously approved these changes Mar 8, 2023
@bvolpato bvolpato added the Google LGTM Approval of a pull request to be merged into the repository label Mar 8, 2023
…cast to bson.Document

Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
@Polber Polber requested a review from bvolpato March 9, 2023 14:57
@copybara-service copybara-service bot merged commit 8102cd6 into GoogleCloudPlatform:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Google LGTM Approval of a pull request to be merged into the repository integration testing Migration of integration tests to github MongoDB size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: MongoDBtoBigQuery with UDF: ScriptObjectMirror cannot be cast to bson.Document
3 participants