Skip to content

Use values provided by users for WindowDuration and NumShards #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barata wants to merge 1 commit into from
Closed

Use values provided by users for WindowDuration and NumShards #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/com/google/cloud/teleport/templates/PubsubToAvro.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ public interface Options extends PipelineOptions, StreamingOptions {

@Description("The maximum number of output shards produced when writing.")
@Default.Integer(1)
Integer getNumShards();
ValueProvider<Integer> getNumShards();
Copy link
Member

@sabhyankar sabhyankar Jun 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work unfortunately as AvroIO.Write.withNumShards(int) does not support a ValueProvider as an input. The same goes for some of the other parameters below.


void setNumShards(Integer value);
void setNumShards(ValueProvider<Integer> value);

@Description(
"The window duration in which data will be written. Defaults to 5m. "
Expand All @@ -134,9 +134,9 @@ public interface Options extends PipelineOptions, StreamingOptions {
+ "Nm (for minutes, example: 12m), "
+ "Nh (for hours, example: 2h).")
@Default.String("5m")
String getWindowDuration();
ValueProvider<String> getWindowDuration();

void setWindowDuration(String value);
void setWindowDuration(ValueProvider<String> value);

@Description("The Avro Write Temporary Directory. Must end with /")
@Required
Expand Down