[Test only] Revert "add yaml manifest file"

[Abacn]

Reverts #3227

Testing if gson version change

https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/3227/changes#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R73

caused Kafka test failure

[gemini-code-assist]

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a test-only revert of the 'add yaml manifest file' feature. Its primary purpose is to investigate a Kafka test failure by rolling back changes related to YAML manifest generation and associated gson library version updates. Specifically, it removes the YAML manifest creation and upload logic, and adjusts the gson dependency versions across several modules to an older, potentially more stable, version to determine if the previous gson version change was the root cause of the test failures.

Highlights

• Revert of YAML Manifest Feature: This pull request fully reverts the functionality for adding and managing a YAML manifest file, including its generation, upload logic, and associated test cases.
• Gson Version Adjustment: The gson library version is adjusted across the project. The global gson.version property (previously 2.13.2) is removed from the root pom.xml, and gson.version 2.9.1 is explicitly added to plugins/core-plugin/pom.xml and structured-logging/pom.xml. The gson dependency is also removed from plugins/templates-maven-plugin/pom.xml.
• Code Simplification: The TemplatesReleaseMojo.java file is simplified by removing Gson related imports, the Blueprint record, the yamlManifestName parameter, and the gcsRetryPolicy method, along with all logic pertaining to manifest file creation and GCS retry mechanisms.
• Test Updates: The TemplatesReleaseMojoTest.java file is updated to remove Gson related imports and all test cases and assertions specifically verifying the YAML manifest file generation and upload.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

❌ Patch coverage is 51.35135% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.01%. Comparing base (5edb404) to head (aa41c78).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...loud/teleport/plugin/maven/TemplatesStageMojo.java	46.66%	15 Missing and 1 partial ⚠️
...ud/teleport/plugin/maven/TemplatesReleaseMojo.java	71.42%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3287      +/-   ##
============================================
- Coverage     51.05%   51.01%   -0.05%     
- Complexity     5173     5547     +374     
============================================
  Files           978      978              
  Lines         60469    60400      -69     
  Branches       6633     6616      -17     
============================================
- Hits          30874    30813      -61     
  Misses        27430    27430              
+ Partials       2165     2157       -8     

Components	Coverage Δ
spanner-templates	70.90% <ø> (ø)
spanner-import-export	69.06% <ø> (ø)
spanner-live-forward-migration	80.04% <ø> (ø)
spanner-live-reverse-replication	77.63% <ø> (ø)
spanner-bulk-migration	88.08% <ø> (ø)

Files with missing lines	Coverage Δ
...gle/cloud/teleport/plugin/DockerfileGenerator.java	90.00% <ø> (ø)
...ud/teleport/plugin/maven/TemplatesReleaseMojo.java	50.00% <71.42%> (-12.11%)	⬇️
...loud/teleport/plugin/maven/TemplatesStageMojo.java	13.12% <46.66%> (-4.75%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Abacn]

Kafka PR still failing for same reason: https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/21546235176/job/62088201331?pr=3287

[Abacn]

reverting both #3268 and #3227 didn't worker either.

Also checked internally, latest Dataflow router rollout completed on Jan 29, not matching the start of breakage (Jan 30 afternoon EST)