-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(Spanner): Bulk template generated column support #3254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(Spanner): Bulk template generated column support #3254
Conversation
Summary of ChangesHello @pratickchokhani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the data transformation pipeline for Spanner by introducing robust handling for generated columns. The core change involves identifying these read-only columns and ensuring they are not included in write operations, thereby preventing errors and maintaining data integrity. This improvement is crucial for seamless data migration and synchronization with Spanner, especially when dealing with schemas that leverage generated fields. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (27.27%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3254 +/- ##
============================================
+ Coverage 50.93% 56.34% +5.40%
+ Complexity 5159 1724 -3435
============================================
Files 977 473 -504
Lines 60351 26886 -33465
Branches 6596 2840 -3756
============================================
- Hits 30740 15149 -15591
+ Misses 27461 10830 -16631
+ Partials 2150 907 -1243
🚀 New features to boost your workflow:
|
61d8e6e to
7556052
Compare
7556052 to
ba62c70
Compare
…g data transformation to prevent writing to read-only fields.
ba62c70 to
2735749
Compare
No description provided.