-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add integration tests to live spanner migration for table and index limits #3037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add integration tests to live spanner migration for table and index limits #3037
Conversation
…migration from a MySQL database to a Spanner instance This includes tests for the following limits: - max size of a STRING cell - max size of a data per cell - max size of a primary key - max size of an index - total size of non-key columns (currently ignored because of OOM issues with low-provisioned VMs/DBs)
Summary of ChangesHello @nmemond, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the robustness of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3037 +/- ##
============================================
+ Coverage 50.80% 54.75% +3.94%
+ Complexity 5124 2241 -2883
============================================
Files 976 490 -486
Lines 60058 28431 -31627
Branches 6569 2994 -3575
============================================
- Hits 30511 15566 -14945
+ Misses 27406 11921 -15485
+ Partials 2141 944 -1197
🚀 New features to boost your workflow:
|
|
Can we please rebase this? |
Done. |
This adds integration tests to verify table and index limits during live spanner data migration.
This includes tests for the following limits: