Skip to content

Conversation

@taherkl
Copy link
Contributor

@taherkl taherkl commented Feb 18, 2025

This pull request introduces the following key enhancements:

  1. Enhanced Null Handling:
  • Improved handling of null values for all column types, including String columns, ensuring consistent data integrity and preventing unintended null conversions.
  • This enhancement covers all possible column data types, providing a more robust and error-free data transformation process.
  1. Custom Transformation Logic:
  • Added support for custom transformation logic specifically for Spanner to Cassandra Reverse migrations.
  • This includes the ability to handle complex data type mappings and custom transformations needed for seamless data synchronization between Cassandra and Spanner.

* sync upstream/main (#98)

* Custom transformation fixes

* Added Custom Transformation

* Added Custom Transformation

* Added Fixes

* Address null to all columns

* Added Null Assert

* Added Timeout fixes

* Added Spotless fixes

* reverse merge the main

* Added Custom Fixes

* Added Drop Keys

---------
Move null test case into previous tests
taherkl and others added 2 commits February 18, 2025 13:16
Referesh `SpannerToSourceDbCustomTransformationIT` tables for re-runs…
@taherkl taherkl marked this pull request as ready for review February 18, 2025 12:35
@taherkl taherkl requested a review from a team as a code owner February 18, 2025 12:35
@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.38%. Comparing base (797c173) to head (8a7c990).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...v2/templates/dbutils/dml/CassandraTypeHandler.java 66.66% 1 Missing and 1 partial ⚠️
...2/templates/dbutils/dml/CassandraDMLGenerator.java 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2201      +/-   ##
============================================
+ Coverage     47.17%   47.38%   +0.21%     
- Complexity     4052     4432     +380     
============================================
  Files           876      880       +4     
  Lines         52325    52590     +265     
  Branches       5522     5568      +46     
============================================
+ Hits          24686    24922     +236     
- Misses        25881    25897      +16     
- Partials       1758     1771      +13     
Components Coverage Δ
spanner-templates 69.41% <90.62%> (+0.24%) ⬆️
spanner-import-export 65.86% <ø> (+0.14%) ⬆️
spanner-live-forward-migration 77.62% <ø> (+0.32%) ⬆️
spanner-live-reverse-replication 79.67% <90.62%> (+0.20%) ⬆️
spanner-bulk-migration 88.42% <ø> (+0.10%) ⬆️
Files with missing lines Coverage Δ
...2/templates/dbutils/dml/CassandraDMLGenerator.java 91.21% <96.15%> (+0.81%) ⬆️
...v2/templates/dbutils/dml/CassandraTypeHandler.java 81.48% <66.66%> (-2.87%) ⬇️

... and 22 files with indirect coverage changes

@akashthawaitcc
Copy link
Contributor

@shreyakhajanchi if everything looks good can you merge this PR ?

@shreyakhajanchi shreyakhajanchi merged commit bc90790 into GoogleCloudPlatform:main Mar 3, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants