Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Feb 13, 2025

apply same fix of #1595 to the other two workflows

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.29%. Comparing base (40e1a8b) to head (653a4d5).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2193      +/-   ##
============================================
+ Coverage     46.97%   51.29%   +4.31%     
+ Complexity     4047     1651    -2396     
============================================
  Files           876      448     -428     
  Lines         52203    24124   -28079     
  Branches       5502     2371    -3131     
============================================
- Hits          24524    12374   -12150     
+ Misses        25922    11030   -14892     
+ Partials       1757      720    -1037     
Components Coverage Δ
spanner-templates 70.43% <ø> (+1.50%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 76.54% <ø> (ø)
spanner-live-reverse-replication 78.80% <ø> (ø)
spanner-bulk-migration 87.94% <ø> (ø)

see 446 files with indirect coverage changes

@Abacn
Copy link
Contributor Author

Abacn commented Feb 13, 2025

R: @VardhanThigle @damccorm

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm
Copy link
Contributor

Test failures are clearly unrelated to this PR, but I'll try rerunning to get a green signal if we can - seems unlikely though given https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/workflows/spanner-pr.yml

@damccorm
Copy link
Contributor

Test failures are clearly unrelated to this PR, but I'll try rerunning to get a green signal if we can - seems unlikely though given https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/workflows/spanner-pr.yml

To be clear, we shouldn't block merging on this

@Abacn
Copy link
Contributor Author

Abacn commented Feb 14, 2025

SpannerToSourceDbCustomTransformationIT
is a known flaky test and is acknowledged by owner team, see #2191 (comment)

@damccorm
Copy link
Contributor

Sounds good, lets just merge

@damccorm damccorm merged commit 7b7081b into GoogleCloudPlatform:main Feb 14, 2025
19 of 21 checks passed
@Abacn Abacn deleted the concurrent-group branch February 14, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants