-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix github action concurrency to cancel old commit on new push #2193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2193 +/- ##
============================================
+ Coverage 46.97% 51.29% +4.31%
+ Complexity 4047 1651 -2396
============================================
Files 876 448 -428
Lines 52203 24124 -28079
Branches 5502 2371 -3131
============================================
- Hits 24524 12374 -12150
+ Misses 25922 11030 -14892
+ Partials 1757 720 -1037
|
12372b9 to
653a4d5
Compare
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Test failures are clearly unrelated to this PR, but I'll try rerunning to get a green signal if we can - seems unlikely though given https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/workflows/spanner-pr.yml |
To be clear, we shouldn't block merging on this |
|
SpannerToSourceDbCustomTransformationIT |
|
Sounds good, lets just merge |
apply same fix of #1595 to the other two workflows