-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add test coverage for non-ascii Template parameter #2192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
85dc057 to
67685be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2192 +/- ##
============================================
+ Coverage 46.97% 47.06% +0.08%
- Complexity 4047 4050 +3
============================================
Files 876 876
Lines 52203 52218 +15
Branches 5502 5505 +3
============================================
+ Hits 24524 24577 +53
+ Misses 25922 25881 -41
- Partials 1757 1760 +3
|
|
Two tests failed: JdbcToBigQueryIT.testMySqlToBigQueryWithStorageWriteApi JdbcToBigQueryIT.testMySqlToBigQueryFlexWithDlq Looks like BigQuery storage write API does not support non-ascii field name |
67685be to
04ea806
Compare
76e018b to
408435f
Compare
408435f to
f77bdf6
Compare
...bc-to-googlecloud/src/test/java/com/google/cloud/teleport/v2/templates/JdbcToBigQueryIT.java
Show resolved
Hide resolved
|
R: @damccorm |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.