Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Feb 12, 2025

Fix #2179

Beam 2.63.0 removed beam-sdks-java-io-amazon-web-services

@Abacn Abacn added the improvement Making existing code better label Feb 12, 2025
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.96%. Comparing base (b93cad8) to head (106ffbe).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...e/cloud/teleport/v2/templates/KinesisToPubsub.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2182      +/-   ##
============================================
- Coverage     46.97%   46.96%   -0.02%     
+ Complexity     4049     4048       -1     
============================================
  Files           876      876              
  Lines         52193    52198       +5     
  Branches       5502     5502              
============================================
- Hits          24517    24514       -3     
- Misses        25920    25928       +8     
  Partials       1756     1756              
Components Coverage Δ
spanner-templates 68.92% <ø> (ø)
spanner-import-export 65.74% <ø> (ø)
spanner-live-forward-migration 76.50% <ø> (ø)
spanner-live-reverse-replication 78.77% <ø> (ø)
spanner-bulk-migration 87.94% <ø> (ø)
Files with missing lines Coverage Δ
.../teleport/v2/transforms/KinesisDataTransforms.java 0.00% <ø> (ø)
...e/cloud/teleport/v2/templates/KinesisToPubsub.java 5.71% <0.00%> (-0.96%) ⬇️

... and 2 files with indirect coverage changes

@Abacn
Copy link
Contributor Author

Abacn commented Feb 13, 2025

a test failing in googlecloud-to-googlecloud, not related to this change

2025-02-13T01:25:17.4207432Z [ERROR] Tests run: 16, Failures: 0, Errors: 12, Skipped: 0, Time elapsed: 1,071.553 s <<< FAILURE! - in com.google.cloud.teleport.v2.templates.bigtablechangestreamstopubsub.BigtableChangeStreamsToPubSubIT
2025-02-13T01:25:17.4209786Z [ERROR] testJsonWithSchemaCharsetAndB64Val[no-dlq-retry-false](com.google.cloud.teleport.v2.templates.bigtablechangestreamstopubsub.BigtableChangeStreamsToPubSubIT)  Time elapsed: 389.774 s  <<< ERROR!
2025-02-13T01:25:17.4308165Z [ERROR] testAvroWithNoSchemaNoVal[no-dlq-retry-true](com.google.cloud.teleport.v2.templates.bigtablechangestreamstopubsub.BigtableChangeStreamsToPubSubIT)  Time elapsed: 389.783 s  <<< ERROR!
2025-02-13T01:25:17.4309909Z org.apache.beam.it.gcp.bigtable.BigtableResourceManagerException: Failed to create app profile.
2025-02-13T01:25:17.4361205Z [ERROR] testJsonWithSchemaCharsetAndB64Val[no-dlq-retry-true](com.google.cloud.teleport.v2.templates.bigtablechangestreamstopubsub.BigtableChangeStreamsToPubSubIT)  Time elapsed: 389.777 s  <<< ERROR!
2025-02-13T01:25:17.4361719Z org.apache.beam.it.gcp.bigtable.BigtableResourceManagerException: Failed to create app profile.
2025-02-13T01:25:17.4408223Z [ERROR] testDeadLetterQueueDelivery[no-dlq-retry-false](com.google.cloud.teleport.v2.templates.bigtablechangestreamstopubsub.BigtableChangeStreamsToPubSubIT)  Time elapsed: 389.773 s  <<< ERROR!
2025-02-13T01:25:17.4408748Z org.apache.beam.it.gcp.bigtable.BigtableResourceManagerException: Failed to create app profile.
2025-02-13T01:25:17.4454985Z [ERROR] testJsonNoSchemaCharsetsAndBase64Values[no-dlq-retry-true](com.google.cloud.teleport.v2.templates.bigtablechangestreamstopubsub.BigtableChangeStreamsToPubSubIT)  Time elapsed: 389.839 s  <<< ERROR!
2025-02-13T01:25:17.4455503Z org.apache.beam.it.gcp.bigtable.BigtableResourceManagerException: Failed to create app profile.
2025-02-13T01:25:17.4501562Z [ERROR] testAvroWithSchema[no-dlq-retry-false](com.google.cloud.teleport.v2.templates.bigtablechangestreamstopubsub.BigtableChangeStreamsToPubSubIT)  Time elapsed: 389.767 s  <<< ERROR!
2025-02-13T01:25:17.4502174Z org.apache.beam.it.gcp.bigtable.BigtableResourceManagerException: Failed to create app profile.
...

@Abacn
Copy link
Contributor Author

Abacn commented Feb 13, 2025

R: @damccorm

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn Abacn merged commit 30020c0 into GoogleCloudPlatform:main Feb 13, 2025
14 of 16 checks passed
@Abacn Abacn deleted the aws2 branch February 13, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Migrate to AWS2 API for kinesis-to-pubsub template

2 participants