Skip to content

Conversation

@claudevdm
Copy link
Contributor

No description provided.

@claudevdm claudevdm force-pushed the datastream-array branch 2 times, most recently from 0ef7783 to b218ac6 Compare January 28, 2025 03:32
@liferoad liferoad added bug-fix improvement Making existing code better and removed bug-fix labels Jan 28, 2025
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 53.57143% with 13 lines in your changes missing coverage. Please review.

Project coverage is 46.88%. Comparing base (409a5cc) to head (7741dd9).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...oud/teleport/v2/utils/DatastreamToPostgresDML.java 53.57% 8 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2154      +/-   ##
============================================
+ Coverage     46.74%   46.88%   +0.14%     
- Complexity     3977     4018      +41     
============================================
  Files           873      874       +1     
  Lines         51871    52070     +199     
  Branches       5429     5461      +32     
============================================
+ Hits          24248    24415     +167     
- Misses        25897    25909      +12     
- Partials       1726     1746      +20     
Components Coverage Δ
spanner-templates 68.79% <ø> (+0.15%) ⬆️
spanner-import-export 65.61% <ø> (+0.01%) ⬆️
spanner-live-forward-migration 76.50% <ø> (+0.01%) ⬆️
spanner-live-reverse-replication 78.67% <ø> (+0.28%) ⬆️
spanner-bulk-migration 87.87% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...oogle/cloud/teleport/v2/utils/DatastreamToDML.java 9.09% <ø> (+1.23%) ⬆️
...oud/teleport/v2/utils/DatastreamToPostgresDML.java 56.25% <53.57%> (+1.25%) ⬆️

... and 17 files with indirect coverage changes

@claudevdm claudevdm marked this pull request as ready for review January 28, 2025 22:34
@claudevdm claudevdm requested a review from a team as a code owner January 28, 2025 22:34
@claudevdm claudevdm merged commit 2631a1d into GoogleCloudPlatform:main Jan 29, 2025
16 of 17 checks passed
taherkl added a commit to ollionorg/DataflowTemplates-fork that referenced this pull request Jan 30, 2025
Support avro arrays for postgres insertion. (GoogleCloudPlatform#2154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants