-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add UUID support in import/export templates #2145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...gle-cloud-platform/src/main/java/org/apache/beam/it/gcp/spanner/matchers/SpannerAsserts.java
Show resolved
Hide resolved
...gle-cloud-platform/src/main/java/org/apache/beam/it/gcp/spanner/matchers/SpannerAsserts.java
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/spanner/AvroSchemaToDdlConverter.java
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/spanner/BuildReadFromTableOperations.java
Show resolved
Hide resolved
v1/src/test/java/com/google/cloud/teleport/spanner/AvroRecordConverterTest.java
Show resolved
Hide resolved
v1/src/test/java/com/google/cloud/teleport/spanner/ExportPipelineIT.java
Show resolved
Hide resolved
v1/src/test/java/com/google/cloud/teleport/spanner/SpannerRecordConverterTest.java
Outdated
Show resolved
Hide resolved
darshan-sj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Left a few comments.
v1/src/main/java/com/google/cloud/teleport/spanner/SpannerRecordConverter.java
Show resolved
Hide resolved
v1/src/test/java/com/google/cloud/teleport/spanner/ExportPipelineIT.java
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/spanner/AvroSchemaToDdlConverter.java
Show resolved
Hide resolved
darshan-sj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Unrelated test failure in Spanner PR / Dataflow Templates Integration Tests (pull_request): com.google.cloud.teleport.v2.templates.SpannerToSourceDbCustomTransformationIT |
|
Please sync the change to Beam's SpannerIO : https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchema.java LocalSpannerIO is going to be teardown |
|
LocalSpannerIO does not admit changes that not already in Beam's SpannerIO, and is going to be teardown #1429 will affect part of the functionality added in this PR |
feat: Add support for importing/exporting UUID columns as strings
Manual Tests in Cloud Devel
Avro
GSQL
Export
Import
Postgres
Export
Import
CSV
GSQL
Export
Import
Postgres
Export
Import