Skip to content

Fix precision error for datetime #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Deep1998 merged 1 commit into from
Jan 6, 2025
Merged

Fix precision error for datetime #2106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...java/com/google/cloud/teleport/v2/spanner/migrations/avro/GenericRecordTypeConvertor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,10 @@ static String handleRecordFieldType(String fieldName, GenericRecord element, Sch
// Convert to timestamp string.
Long totalMicros = TimeUnit.DAYS.toMicros(Long.valueOf(element.get("date").toString()));
totalMicros += Long.valueOf(element.get("time").toString());
Instant timestamp = Instant.ofEpochSecond(TimeUnit.MICROSECONDS.toSeconds(totalMicros));
Instant timestamp =
Instant.ofEpochSecond(
TimeUnit.MICROSECONDS.toSeconds(totalMicros),
TimeUnit.MICROSECONDS.toNanos(totalMicros % TimeUnit.SECONDS.toMicros(1)));
return timestamp.atOffset(ZoneOffset.UTC).format(DateTimeFormatter.ISO_OFFSET_DATE_TIME);
} else if (fieldSchema.getName().equals("interval")) {
// TODO: For MySQL, we ignore the months field. This might require source-specific handling
Expand Down
4 changes: 2 additions & 2 deletions .../com/google/cloud/teleport/v2/spanner/migrations/avro/GenericRecordTypeConvertorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,9 @@ public void testHandleRecordFieldType() {
result =
GenericRecordTypeConvertor.handleRecordFieldType(
"date_time_column",
AvroTestingHelper.createDatetimeRecord(738991, 48035000000L),
AvroTestingHelper.createDatetimeRecord(20091, 31703699206L),
AvroTestingHelper.DATETIME_SCHEMA);
assertEquals("Test datetime conversion: ", "3993-04-16T13:20:35Z", result);
assertEquals("Test datetime conversion: ", "2025-01-03T08:48:23.699206Z", result);

// Tests for interval type.
result =
Expand Down
Loading