Skip to content

Fix Spanner Load tests and add display test report #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darshan-sj merged 2 commits into from
Dec 31, 2024
Merged

Fix Spanner Load tests and add display test report #2092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6ecb5b
correcting lt failures
darshan-sj Dec 29, 2024
1a8b5e6
Adding test report
darshan-sj Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/spanner-load-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,16 @@ jobs:
with:
name: surefire-test-results
path: '**/surefire-reports/TEST-*.xml'
retention-days: 1
retention-days: 30
- name: Load Test report on GitHub
uses: dorny/test-reporter@v1
if: always()
with:
name: Load Test report on GitHub
path: '**/surefire-reports/TEST-*.xml'
reporter: java-junit
only-summary: 'false'
token: ${{ secrets.GITHUB_TOKEN }}
- name: Cleanup Java Environment
uses: ./.github/actions/cleanup-java-env
observe_load_tests:
Expand Down
13 changes: 11 additions & 2 deletions .github/workflows/spanner-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ concurrency:
env:
MAVEN_OPTS: -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=error

permissions: read-all
permissions: write-all

jobs:
spotless_check:
Expand Down Expand Up @@ -182,7 +182,16 @@ jobs:
with:
name: surefire-test-results
path: '**/surefire-reports/TEST-*.xml'
retention-days: 1
retention-days: 10
- name: Integration Test report on GitHub
uses: dorny/test-reporter@v1
if: always()
with:
name: Integration Test report on GitHub
path: '**/surefire-reports/TEST-*.xml'
reporter: java-junit
only-summary: 'false'
token: ${{ secrets.GITHUB_TOKEN }}
- name: Cleanup Java Environment
uses: ./.github/actions/cleanup-java-env
java_load_tests_templates:
Expand Down
2 changes: 1 addition & 1 deletion ...ogle-cloud-platform/src/main/java/org/apache/beam/it/gcp/monitoring/MonitoringClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@

ListTimeSeriesRequest request =
ListTimeSeriesRequest.newBuilder()
.setName(projectId)
.setName(ProjectName.of(projectId).toString())

Check warning on line 440 in it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/monitoring/MonitoringClient.java

View check run for this annotation

Codecov / codecov/patch

it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/monitoring/MonitoringClient.java#L440 

Added line #L440 was not covered by tests
.setFilter(filter)
.setInterval(interval)
.setAggregation(aggregation)
Expand Down
2 changes: 1 addition & 1 deletion ...gle-cloud-platform/src/main/java/org/apache/beam/it/gcp/pubsub/PubsubResourceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ private Double getAverageOldestUnackedMessageAge(MonitoringClient monitoringClie
TimeInterval interval =
TimeInterval.newBuilder()
.setEndTime(Timestamp.newBuilder().setSeconds(Instant.now().getEpochSecond()))
.setStartTime(Timestamp.newBuilder().setSeconds(Instant.now().getEpochSecond() - 5))
.setStartTime(Timestamp.newBuilder().setSeconds(Instant.now().getEpochSecond() - 20))
.build();

String filterFormat =
Expand Down
1 change: 1 addition & 0 deletions ...st/java/com/google/cloud/teleport/v2/templates/loadtesting/DataStreamToSpannerLTBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ public void getResourceManagerMetrics(Map<String, Double> metrics) {
@After
public void cleanUp() throws IOException {
ResourceManagerUtils.cleanResources(
secretClient,
spannerResourceManager,
pubsubResourceManager,
gcsResourceManager,
Expand Down
Loading