Skip to content

Conversation

@darshan-sj
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 46.36%. Comparing base (cd28d01) to head (8f44fe7).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...va/org/apache/beam/it/jdbc/StaticJDBCResource.java 0.00% 24 Missing ⚠️
...a/org/apache/beam/it/jdbc/StaticMySQLResource.java 0.00% 8 Missing ⚠️
.../apache/beam/it/jdbc/StaticPostgresqlResource.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2063      +/-   ##
============================================
+ Coverage     46.16%   46.36%   +0.19%     
- Complexity     3843     4256     +413     
============================================
  Files           856      862       +6     
  Lines         51010    51340     +330     
  Branches       5365     5394      +29     
============================================
+ Hits          23548    23803     +255     
- Misses        25760    25823      +63     
- Partials       1702     1714      +12     
Components Coverage Δ
spanner-templates 68.25% <ø> (+0.35%) ⬆️
spanner-import-export 65.57% <ø> (-0.02%) ⬇️
spanner-live-forward-migration 76.67% <ø> (+0.25%) ⬆️
spanner-live-reverse-replication 77.93% <ø> (+0.58%) ⬆️
spanner-bulk-migration 87.30% <ø> (+0.13%) ⬆️
Files with missing lines Coverage Δ
...a/org/apache/beam/it/jdbc/StaticMySQLResource.java 0.00% <0.00%> (ø)
.../apache/beam/it/jdbc/StaticPostgresqlResource.java 0.00% <0.00%> (ø)
...va/org/apache/beam/it/jdbc/StaticJDBCResource.java 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

@darshan-sj darshan-sj added the improvement Making existing code better label Dec 29, 2024
@darshan-sj darshan-sj marked this pull request as ready for review December 29, 2024 11:00
@darshan-sj darshan-sj requested a review from a team as a code owner December 29, 2024 11:00
VardhanThigle
VardhanThigle previously approved these changes Dec 30, 2024
@VardhanThigle VardhanThigle added the integration testing Migration of integration tests to github label Dec 30, 2024
@darshan-sj darshan-sj merged commit 2caf29c into GoogleCloudPlatform:main Dec 30, 2024
27 of 29 checks passed
taherkl pushed a commit to ollionorg/DataflowTemplates-fork that referenced this pull request Jan 2, 2025
…oogleCloudPlatform#2063)

* [Sourcedb-to-spanner] Bulk migration Mysql to spanner 1tb Load test

* Updating row counts, added static sql resources

* Renaming the test and addressing comments
taherkl pushed a commit to ollionorg/DataflowTemplates-fork that referenced this pull request Jan 2, 2025
…oogleCloudPlatform#2063)

* [Sourcedb-to-spanner] Bulk migration Mysql to spanner 1tb Load test

* Updating row counts, added static sql resources

* Renaming the test and addressing comments
shreyakhajanchi pushed a commit that referenced this pull request Jan 7, 2025
* Added Connection Helper

* Added Formatter

* Added File Reader

* Refectored

* Added Changes for Schema and Spanner Schema

* Added Schema Changes to read Spanner Table in Schema object

* Added Schema Changes

* Added Changes for Schma

* Added Source Writn Fn Changes

* Added Source Factory Changes

* Added Fixed for the Source factory and Casssandra Connection helper

* Added Cassandra Schema Reader

* Added Pipeline Process

* Removed Unwanted Validation

* Added Access validator

* removed unwanted Return

* Added Thread safe optimization in cassandra Connection helper

* Applied  spotless:apply

* spotless:apply

* Added Constructor for Test case

* Added DUMMY Generator For UT

* Fixed UT for Metadata config (#30)

Co-authored-by: Narendra Rajput <narendra.rajput@ollion.com>

Cassandra metadata PR To accomodate Driver Loader Class (#33)

* Removed *

* Create README.md for UDF samples (#2083)

This commit adds a README.md file to the  directory. The README file provides descriptions for each of the sample Javascript UDF files in the directory, including their purpose and usage examples.

Co-authored-by: labs-code-app[bot] <161369871+labs-code-app[bot]@users.noreply.github.com>

* CassandraDriverConfigLoader from GCS (#2077)

* Added Config File Path

* Added Fix for Loading Driver Options

* Added Dependecy Fixes

* Fix UT

---------

Co-authored-by: labs-code-app[bot] <161369871+labs-code-app[bot]@users.noreply.github.com>
Co-authored-by: Vardhan Vinay Thigle <39047439+VardhanThigle@users.noreply.github.com>

* PR Review Comments (#35)

* Convert it to builder Pattern

* Convert Waring to Error

* remove the unwanted comments

* Removed Unwanted options

* Address the PR

* Address the PR Comments

* Added Missing Getter for Configuration

* Address to removed configuration changes

* removed unwanted getters

* Removal of getter from cassandra dao and test case fixes

* Handle Optionmap in cassandra DAO for serialization

* removed dependecy of getKeyOrder

* Removed And Update Exception

* Fix Checkstyle Voilation

* Missing UT Added (#37)

* Added Dummy Test case

* Removed * from import

* removed unwanted

* Added Fixes

* Added test case and fixes

* Added Some more PR comments

* Added Test case for Cassandra Reader

* Added New testcase

* Added Dependecny

* Update test case  and remove Dependency of Jupiter (#39)

* Update test case  and remove Dependecy of jupiter

* Added UT fixes

* Added Missing Getter for Configuration

* [Sourcedb-to-spanner] Bulk migration Mysql to spanner 1tb Load test (#2063)

* [Sourcedb-to-spanner] Bulk migration Mysql to spanner 1tb Load test

* Updating row counts, added static sql resources

* Renaming the test and addressing comments

* PipelineController Changes for Cassandra (#2086)

* Fix Spanner Load tests and add display test report (#2092)

* correcting lt failures

* Adding test report

* Meta code coverage (#41)

Meta code coverage

* Pr bug fixes (#42)

* Schema Reader Optimization (#43)

* Added Pr Fix related to Changes Year in Javadoc

* Address the revert of 2025 and removal of extra constructor

* Added Extra Testcase to reach target patch

---------

Co-authored-by: taherkl <taher.lakdawala@ollion.com>
Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com>
Co-authored-by: pawankashyapollion <v-pawan.kumar@ollion.com>
Co-authored-by: labs-code-app[bot] <161369871+labs-code-app[bot]@users.noreply.github.com>
Co-authored-by: Vardhan Vinay Thigle <39047439+VardhanThigle@users.noreply.github.com>
Co-authored-by: darshan-sj <darshan-sj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better integration testing Migration of integration tests to github size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants